Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add torch.cuda.synchronize(device=None) #19573

Closed
wants to merge 1 commit into from
Closed

add torch.cuda.synchronize(device=None) #19573

wants to merge 1 commit into from

Conversation

ssnl
Copy link
Collaborator

@ssnl ssnl commented Apr 22, 2019

fixes #19509

@pytorchbot pytorchbot added module: cuda Related to torch.cuda, and CUDA support in general module: typing Related to mypy type annotations labels Apr 22, 2019
@smessmer smessmer requested a review from ezyang April 22, 2019 21:13
@smessmer smessmer added enhancement Not as big of a feature, but technically not a bug. Should be easy to fix triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Apr 22, 2019
@ezyang
Copy link
Contributor

ezyang commented Apr 22, 2019

Waiting on tests

@ssnl
Copy link
Collaborator Author

ssnl commented Apr 23, 2019

@pytorchbot merge this please

@pytorchbot pytorchbot added the merge-this-please Was marked for merge with @pytorchbot merge this please label Apr 23, 2019
facebook-github-bot
facebook-github-bot reviewed Apr 23, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ssnl ssnl deleted the syncdev branch April 23, 2019 15:45
@facebook-github-bot
Copy link
Contributor

@ezyang merged this pull request in dce3d74.

zhangguanheng66 pushed a commit to zhangguanheng66/pytorch that referenced this pull request May 6, 2019
@ssnl
add torch.cuda.synchronize(device=None) (pytorch#19573)
20a7620 
Summary:
fixes pytorch#19509
Pull Request resolved: pytorch#19573

Differential Revision: D15045730

Pulled By: ezyang

fbshipit-source-id: 732721b4b360fc4348ca7c87d4cd1386e7651bdd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@ezyang ezyang ezyang approved these changes

Assignees
No one assigned
Labels
enhancement Not as big of a feature, but technically not a bug. Should be easy to fix merge-this-please Was marked for merge with @pytorchbot merge this please module: cuda Related to torch.cuda, and CUDA support in general module: typing Related to mypy type annotations open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] torch.cuda.synchronize takes in device objects
5 participants
@ssnl @ezyang @facebook-github-bot @smessmer @pytorchbot