Fix tracing bugs where using 1 - x in C++ would cause the size of 1 to get hardcoded.
#20932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to get hardcoded.
pytorchbot
added
oncall: jit
|
fixes #20923 |
suo
approved these changes
May 24, 2019
…e size of 1 to get hardcoded." Fix tracing bugs where using `1 - x` in C++ would cause the size of 1 to get hardcoded. gh-metadata: pytorch pytorch 20932 gh/zdevito/39/head
zdevito
added a commit
to zdevito/ATen
that referenced
this pull request
May 29, 2019
… to get hardcoded. (#20932) Summary: Pull Request resolved: pytorch/pytorch#20932 ghimport-source-id: f0a7f12ffd77aec063a088b18c6b1d108c712df8 Differential Revision: D15501251 Pulled By: zdevito fbshipit-source-id: 91e6e5944d2663b673afde45fc6eed22f31101c4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
1 - xin C++ would cause the size of 1 to get hardcoded. #20932 Fix tracing bugs where using1 - xin C++ would cause the size of 1 to get hardcoded.Differential Revision: D15501251