Add WeakIValue, use in tracer. #21515
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to insert first-class calls to methods, we need to keep ModuleObject -> Value* mappings in the tracer. To do this, this PR creates a WeakIValue to replace WeakTensor, and changes the tracer to use a WeakIValue -> Value* map. wq
pytorchbot
added
oncall: jit
This was referenced Jun 7, 2019
Add WeakIValue, use in tracer. In order to insert first-class calls to methods, we need to keep ModuleObject -> Value* mappings in the tracer. To do this, this PR creates a WeakIValue to replace WeakTensor, and changes the tracer to use a WeakIValue -> Value* map. wq gh-metadata: pytorch pytorch 21515 gh/zdevito/51/head
Add WeakIValue, use in tracer. In order to insert first-class calls to methods, we need to keep ModuleObject -> Value* mappings in the tracer. To do this, this PR creates a WeakIValue to replace WeakTensor, and changes the tracer to use a WeakIValue -> Value* map. wq gh-metadata: pytorch pytorch 21515 gh/zdevito/51/head
Add WeakIValue, use in tracer. In order to insert first-class calls to methods, we need to keep ModuleObject -> Value* mappings in the tracer. To do this, this PR creates a WeakIValue to replace WeakTensor, and changes the tracer to use a WeakIValue -> Value* map. wq gh-metadata: pytorch pytorch 21515 gh/zdevito/51/head
Add WeakIValue, use in tracer. In order to insert first-class calls to methods, we need to keep ModuleObject -> Value* mappings in the tracer. To do this, this PR creates a WeakIValue to replace WeakTensor, and changes the tracer to use a WeakIValue -> Value* map. wq gh-metadata: pytorch pytorch 21515 gh/zdevito/51/head
Add WeakIValue, use in tracer. In order to insert first-class calls to methods, we need to keep ModuleObject -> Value* mappings in the tracer. To do this, this PR creates a WeakIValue to replace WeakTensor, and changes the tracer to use a WeakIValue -> Value* map. wq gh-metadata: pytorch pytorch 21515 gh/zdevito/51/head
Add WeakIValue, use in tracer. In order to insert first-class calls to methods, we need to keep ModuleObject -> Value* mappings in the tracer. To do this, this PR creates a WeakIValue to replace WeakTensor, and changes the tracer to use a WeakIValue -> Value* map. wq gh-metadata: pytorch pytorch 21515 gh/zdevito/51/head
Add WeakIValue, use in tracer. In order to insert first-class calls to methods, we need to keep ModuleObject -> Value* mappings in the tracer. To do this, this PR creates a WeakIValue to replace WeakTensor, and changes the tracer to use a WeakIValue -> Value* map. gh-metadata: pytorch pytorch 21515 gh/zdevito/51/head
This was referenced Jun 8, 2019
Add WeakIValue, use in tracer. In order to insert first-class calls to methods, we need to keep ModuleObject -> Value* mappings in the tracer. To do this, this PR creates a WeakIValue to replace WeakTensor, and changes the tracer to use a WeakIValue -> Value* map. gh-metadata: pytorch pytorch 21515 gh/zdevito/51/head
Add WeakIValue, use in tracer. In order to insert first-class calls to methods, we need to keep ModuleObject -> Value* mappings in the tracer. To do this, this PR creates a WeakIValue to replace WeakTensor, and changes the tracer to use a WeakIValue -> Value* map. gh-metadata: pytorch pytorch 21515 gh/zdevito/51/head
zdevito
commented
Jun 10, 2019
| @@ -720,10 +726,7 @@ namespace intrusive_ptr { | |||
| namespace weak_intrusive_ptr { | |||
|
|
|||
| inline void incref(weak_intrusive_ptr_target* self) { | |||
| auto wptr = c10::weak_intrusive_ptr<weak_intrusive_ptr_target>::reclaim(self); | |||
There was a problem hiding this comment.
This change is necessary because ::reclaim would fail if intrusive_ptr_target has never been a weak ptr before. WeakIValue calls incref in the situation when we are creating a weak_ptr from a strong pointer when none has existed before. This ensures the method does what it says in its name.
Add WeakIValue, use in tracer. In order to insert first-class calls to methods, we need to keep ModuleObject -> Value* mappings in the tracer. To do this, this PR creates a WeakIValue to replace WeakTensor, and changes the tracer to use a WeakIValue -> Value* map. gh-metadata: pytorch pytorch 21515 gh/zdevito/51/head
suo
approved these changes
Jun 12, 2019
| IValue::Payload pl; | ||
| pl.as_intrusive_ptr = temp.lock().release(); | ||
| temp.release(); | ||
| if (!pl.as_intrusive_ptr) { |
There was a problem hiding this comment.
Can we do this check before doing the ownership surgery?
This was referenced Jun 12, 2019
Add WeakIValue, use in tracer. In order to insert first-class calls to methods, we need to keep ModuleObject -> Value* mappings in the tracer. To do this, this PR creates a WeakIValue to replace WeakTensor, and changes the tracer to use a WeakIValue -> Value* map. gh-metadata: pytorch pytorch 21515 gh/zdevito/51/head
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jun 13, 2019
Summary: Pull Request resolved: pytorch/pytorch#21515 ghimport-source-id: 7898a68791db2b5050164ab01d6ca6991e05746d Reviewed By: suo Differential Revision: D15719981 Pulled By: zdevito fbshipit-source-id: 42cf26cf6541bcdf95f1343da3b9228fe2c229da
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
In order to insert first-class calls to methods, we need to keep
ModuleObject -> Value* mappings in the tracer. To do this, this PR
creates a WeakIValue to replace WeakTensor, and changes the tracer
to use a WeakIValue -> Value* map.
wq
Differential Revision: D15719981