Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update quantization to work with first-class modules. #21660

Closed
wants to merge 2 commits into from
Closed

Update quantization to work with first-class modules. #21660

wants to merge 2 commits into from

Conversation

zdevito
Copy link
Contributor

@zdevito zdevito commented Jun 11, 2019 •
edited

Stack from ghstack:

Differential Revision: D15770237

@pytorchbot pytorchbot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Jun 11, 2019
@zdevito zdevito mentioned this pull request Jun 11, 2019
Closed
@ZolotukhinM ZolotukhinM self-requested a review June 11, 2019 22:33
ZolotukhinM
ZolotukhinM approved these changes Jun 11, 2019
View reviewed changes
Copy link

@ZolotukhinM ZolotukhinM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup, LGTM!

This was referenced Jun 12, 2019
Closed
Closed
@zdevito
Update on "Update quantization to work with first-class modules."
19ad3ea 
Update quantization to work with first-class modules.

gh-metadata: pytorch pytorch 21660 gh/zdevito/62/head
@zou3519 zou3519 deleted the gh/zdevito/62/head branch June 13, 2019 00:15
@facebook-github-bot
Copy link
Contributor

@zdevito merged this pull request in d8056cb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZolotukhinM ZolotukhinM ZolotukhinM approved these changes

Assignees
No one assigned
Labels
Merged oncall: jit Add this issue/PR to JIT oncall triage queue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zdevito @facebook-github-bot @ZolotukhinM @pytorchbot @mruberry