-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gradgrad issues with BatchNorm and Advanced Indexing (master) #2269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t needed. These could cause a problem with double backwards because they were std::move'd in Backward.
… indexing case that fails check.
apaszke
approved these changes
Aug 2, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -80,8 +76,6 @@ struct BatchNormBackwardBackward : public Function, public BatchNormParams { | |||
|
|||
virtual void releaseVariables() override; | |||
|
|||
at::Tensor save_mean; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
houseroad
added a commit
to houseroad/pytorch
that referenced
this pull request
Sep 17, 2019
…bcc3b0 (pytorch#26309) Summary: Pull Request resolved: pytorch#26309 Previous import was 95252c2adec185e305e34486c6756ece9aa8f57f Included changes: - **[1316afc9](onnx/onnx@1316afc9)**: Update IR doc to clarify initializers are permitted as node inputs (pytorch#2320) <G. Ramalingam> - **[5e920d0c](onnx/onnx@5e920d0c)**: Avoid uses of special chars (pytorch#2315) <Wei-Sheng Chin> - **[2fa08b0f](onnx/onnx@2fa08b0f)**: Regenerate ONNX proto and add release date to ver 6 IR (pytorch#2316) <Wei-Sheng Chin> - **[adf9c7a3](onnx/onnx@adf9c7a3)**: Add description of default type about y_zero_point (pytorch#2110) <Takeshi Watanabe> - **[ee7072c7](onnx/onnx@ee7072c7)**: Support make_attribute empty string (pytorch#2129) <shjwudp> - **[f913b6e7](onnx/onnx@f913b6e7)**: More unsqueeze tests (pytorch#2200) <James Allingham> - **[57b51937](onnx/onnx@57b51937)**: Fix resize shape inference issue in opset10 (pytorch#2294) <Bowen Bao> - **[d7595f34](onnx/onnx@d7595f34)**: Sequence related ops (pytorch#2249) <Bowen Bao> - **[599f3da9](onnx/onnx@599f3da9)**: Add helper function update_inputs_outputs_dims to tools (pytorch#2148) <Bowen Bao> - **[3e6382bc](onnx/onnx@3e6382bc)**: Update documentation about required input output types (pytorch#2310) <G. Ramalingam> - **[0c765d9b](onnx/onnx@0c765d9b)**: Shape inference for NMS (pytorch#2269) <Hariharan Seshadri> - **[89266710](onnx/onnx@89266710)**: Fix extra collect_snippets warning (pytorch#2277) (pytorch#2307) <Lutz Roeder> Test Plan: ci Reviewed By: hl475 Differential Revision: D17403954 fbshipit-source-id: 8f7cbf77b7e09b73db2015f3e0f436772482b322
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 17, 2019
…bcc3b0 (#26309) Summary: Pull Request resolved: #26309 Previous import was 95252c2adec185e305e34486c6756ece9aa8f57f Included changes: - **[1316afc9](onnx/onnx@1316afc9)**: Update IR doc to clarify initializers are permitted as node inputs (#2320) <G. Ramalingam> - **[5e920d0c](onnx/onnx@5e920d0c)**: Avoid uses of special chars (#2315) <Wei-Sheng Chin> - **[2fa08b0f](onnx/onnx@2fa08b0f)**: Regenerate ONNX proto and add release date to ver 6 IR (#2316) <Wei-Sheng Chin> - **[adf9c7a3](onnx/onnx@adf9c7a3)**: Add description of default type about y_zero_point (#2110) <Takeshi Watanabe> - **[ee7072c7](onnx/onnx@ee7072c7)**: Support make_attribute empty string (#2129) <shjwudp> - **[f913b6e7](onnx/onnx@f913b6e7)**: More unsqueeze tests (#2200) <James Allingham> - **[57b51937](onnx/onnx@57b51937)**: Fix resize shape inference issue in opset10 (#2294) <Bowen Bao> - **[d7595f34](onnx/onnx@d7595f34)**: Sequence related ops (#2249) <Bowen Bao> - **[599f3da9](onnx/onnx@599f3da9)**: Add helper function update_inputs_outputs_dims to tools (#2148) <Bowen Bao> - **[3e6382bc](onnx/onnx@3e6382bc)**: Update documentation about required input output types (#2310) <G. Ramalingam> - **[0c765d9b](onnx/onnx@0c765d9b)**: Shape inference for NMS (#2269) <Hariharan Seshadri> - **[89266710](onnx/onnx@89266710)**: Fix extra collect_snippets warning (#2277) (#2307) <Lutz Roeder> Test Plan: ci Reviewed By: hl475 Differential Revision: D17403954 fbshipit-source-id: 78a9c3ecf5aa7f7a0ba8ea30286eab61ee903772
IvanYashchuk
pushed a commit
to IvanYashchuk/pytorch
that referenced
this pull request
Jan 5, 2023
…pr_simplify" printing (pytorch#2269)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two tests for gradchecks:
That backward is reentrant
That input grad sizes match input sizez.
Uncovers an issue with BatchNorm which is now fixed
Uncovers an issue with advanced indexing which is also now fixed.