Typo fix #2320
Merged
Typo fix #2320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ArEsKay3 can you rebase your first commit off of master and then re-submit so we don't have a merge commit |
|
there's a squash & merge option that I used. thanks @ArEsKay3 ! |
zou3519
pushed a commit
to zou3519/pytorch
that referenced
this pull request
Mar 30, 2018
* Revert update on top_k_op * Speed transpose up on gpu Speed transpose up on gpu
houseroad
added a commit
to houseroad/pytorch
that referenced
this pull request
Sep 17, 2019
…bcc3b0 (pytorch#26309) Summary: Pull Request resolved: pytorch#26309 Previous import was 95252c2adec185e305e34486c6756ece9aa8f57f Included changes: - **[1316afc9](onnx/onnx@1316afc9)**: Update IR doc to clarify initializers are permitted as node inputs (pytorch#2320) <G. Ramalingam> - **[5e920d0c](onnx/onnx@5e920d0c)**: Avoid uses of special chars (pytorch#2315) <Wei-Sheng Chin> - **[2fa08b0f](onnx/onnx@2fa08b0f)**: Regenerate ONNX proto and add release date to ver 6 IR (pytorch#2316) <Wei-Sheng Chin> - **[adf9c7a3](onnx/onnx@adf9c7a3)**: Add description of default type about y_zero_point (pytorch#2110) <Takeshi Watanabe> - **[ee7072c7](onnx/onnx@ee7072c7)**: Support make_attribute empty string (pytorch#2129) <shjwudp> - **[f913b6e7](onnx/onnx@f913b6e7)**: More unsqueeze tests (pytorch#2200) <James Allingham> - **[57b51937](onnx/onnx@57b51937)**: Fix resize shape inference issue in opset10 (pytorch#2294) <Bowen Bao> - **[d7595f34](onnx/onnx@d7595f34)**: Sequence related ops (pytorch#2249) <Bowen Bao> - **[599f3da9](onnx/onnx@599f3da9)**: Add helper function update_inputs_outputs_dims to tools (pytorch#2148) <Bowen Bao> - **[3e6382bc](onnx/onnx@3e6382bc)**: Update documentation about required input output types (pytorch#2310) <G. Ramalingam> - **[0c765d9b](onnx/onnx@0c765d9b)**: Shape inference for NMS (pytorch#2269) <Hariharan Seshadri> - **[89266710](onnx/onnx@89266710)**: Fix extra collect_snippets warning (pytorch#2277) (pytorch#2307) <Lutz Roeder> Test Plan: ci Reviewed By: hl475 Differential Revision: D17403954 fbshipit-source-id: 8f7cbf77b7e09b73db2015f3e0f436772482b322
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 17, 2019
…bcc3b0 (#26309) Summary: Pull Request resolved: #26309 Previous import was 95252c2adec185e305e34486c6756ece9aa8f57f Included changes: - **[1316afc9](onnx/onnx@1316afc9)**: Update IR doc to clarify initializers are permitted as node inputs (#2320) <G. Ramalingam> - **[5e920d0c](onnx/onnx@5e920d0c)**: Avoid uses of special chars (#2315) <Wei-Sheng Chin> - **[2fa08b0f](onnx/onnx@2fa08b0f)**: Regenerate ONNX proto and add release date to ver 6 IR (#2316) <Wei-Sheng Chin> - **[adf9c7a3](onnx/onnx@adf9c7a3)**: Add description of default type about y_zero_point (#2110) <Takeshi Watanabe> - **[ee7072c7](onnx/onnx@ee7072c7)**: Support make_attribute empty string (#2129) <shjwudp> - **[f913b6e7](onnx/onnx@f913b6e7)**: More unsqueeze tests (#2200) <James Allingham> - **[57b51937](onnx/onnx@57b51937)**: Fix resize shape inference issue in opset10 (#2294) <Bowen Bao> - **[d7595f34](onnx/onnx@d7595f34)**: Sequence related ops (#2249) <Bowen Bao> - **[599f3da9](onnx/onnx@599f3da9)**: Add helper function update_inputs_outputs_dims to tools (#2148) <Bowen Bao> - **[3e6382bc](onnx/onnx@3e6382bc)**: Update documentation about required input output types (#2310) <G. Ramalingam> - **[0c765d9b](onnx/onnx@0c765d9b)**: Shape inference for NMS (#2269) <Hariharan Seshadri> - **[89266710](onnx/onnx@89266710)**: Fix extra collect_snippets warning (#2277) (#2307) <Lutz Roeder> Test Plan: ci Reviewed By: hl475 Differential Revision: D17403954 fbshipit-source-id: 78a9c3ecf5aa7f7a0ba8ea30286eab61ee903772
jjsjann123
added a commit
to jjsjann123/pytorch
that referenced
this pull request
Jan 17, 2023
Revert "Revert CMakeLists.txt as build fails with clang due to unused variables (pytorch#2315)", so more compiler warning are enabled. fixing compiler warnings. Verified on both gcc & clang-14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing what I'm pretty sure is a typo in the distributeddataparallel code for one device per system case.