implement bool_tensor.bernoulli_ #25076
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
module: cpu
vishwakftw
reviewed
Aug 23, 2019
| @@ -132,7 +132,7 @@ Tensor& bernoulli_out(Tensor& result, const Tensor& self, Generator* gen) { | |||
| } | |||
|
|
|||
| Tensor& bernoulli_tensor_cpu_(Tensor& self, const Tensor& p_, Generator* gen) { | |||
| AT_DISPATCH_ALL_TYPES(self.scalar_type(), "bernoulli_tensor_cpu_self_", [&] { | |||
| AT_DISPATCH_ALL_TYPES_AND(at::ScalarType::Bool, self.scalar_type(), "bernoulli_tensor_cpu_self_", [&] { | |||
There was a problem hiding this comment.
Why is there a difference between CPU and CUDA bernoulli_ implementations w.r.t. supporting half precision?
There was a problem hiding this comment.
I think a lot ops are not supported for CPU half due to inefficiency.
|
@izdeby could you review? |
izdeby
approved these changes
Aug 27, 2019
|
@pytorchbot merge this please |
pytorchbot
added
the
merge-this-please
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 28, 2019
Summary: Fixes pytorch/pytorch#25072 Pull Request resolved: pytorch/pytorch#25076 Differential Revision: D17073453 Pulled By: ezyang fbshipit-source-id: 42410da8c9911c1d7b3543bde740c7e66ae0cc1c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25072