[jit] Emit script function calls during tracing. #25089
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when the tracer encountered a scripted function (or method), it inlined the function into the graph. Now, we emit a CallFunction or CallMethod node instead.
pytorchbot
added
oncall: jit
Closed
suo
added a commit
that referenced
this pull request
Aug 23, 2019
Previously, when the tracer encountered a scripted function (or method), it inlined the function into the graph. Now, we emit a CallFunction or CallMethod node instead. ghstack-source-id: a20b41b56c12143743e0842a17adf6ffe159480b Pull Request resolved: #25089
Previously, when the tracer encountered a scripted function (or method), it inlined the function into the graph. Now, we emit a CallFunction or CallMethod node instead. Differential Revision: [D16987936](https://our.internmc.facebook.com/intern/diff/D16987936)
Previously, when the tracer encountered a scripted function (or method), it inlined the function into the graph. Now, we emit a CallFunction or CallMethod node instead. Differential Revision: [D16987936](https://our.internmc.facebook.com/intern/diff/D16987936)
Previously, when the tracer encountered a scripted function (or method), it inlined the function into the graph. Now, we emit a CallFunction or CallMethod node instead. Differential Revision: [D16987936](https://our.internmc.facebook.com/intern/diff/D16987936)
Previously, when the tracer encountered a scripted function (or method), it inlined the function into the graph. Now, we emit a CallFunction or CallMethod node instead. Differential Revision: [D16987936](https://our.internmc.facebook.com/intern/diff/D16987936)
suo
added a commit
that referenced
this pull request
Aug 23, 2019
Previously, when the tracer encountered a scripted function (or method), it inlined the function into the graph. Now, we emit a CallFunction or CallMethod node instead. ghstack-source-id: 9809a277ec1f601125ef22b8842027253b6eb7aa Pull Request resolved: #25089
zdevito
approved these changes
Aug 24, 2019
| @@ -10547,6 +10546,7 @@ def traced_fn(x): | |||
| self.assertTrue(len(list(traced_fn.graph.inputs())) == 1) | |||
| FileCheck().check("aten::mm").check("aten::add").run(str(traced_fn.graph)) | |||
|
|
|||
| @_tmp_donotuse_dont_inline_everything | |||
| @@ -565,6 +565,8 @@ def graph_diagnostic_info(): | |||
| break # Graphs have already diverged | |||
|
|
|||
| if n_mod.kind() == 'prim::Constant' and not (n_mod.mustBeNone() or n_check.mustBeNone()): | |||
| if not n_mod.hasAttribute('value'): | |||
Previously, when the tracer encountered a scripted function (or method), it inlined the function into the graph. Now, we emit a CallFunction or CallMethod node instead. Differential Revision: [D16987936](https://our.internmc.facebook.com/intern/diff/D16987936)
suo
added a commit
that referenced
this pull request
Aug 28, 2019
Previously, when the tracer encountered a scripted function (or method), it inlined the function into the graph. Now, we emit a CallFunction or CallMethod node instead. ghstack-source-id: 5d5fb8513f35fd2574f795b239ec1d29838a1e70 Pull Request resolved: #25089
Previously, when the tracer encountered a scripted function (or method), it inlined the function into the graph. Now, we emit a CallFunction or CallMethod node instead. Differential Revision: [D16987936](https://our.internmc.facebook.com/intern/diff/D16987936)
Previously, when the tracer encountered a scripted function (or method), it inlined the function into the graph. Now, we emit a CallFunction or CallMethod node instead. Differential Revision: [D16987936](https://our.internmc.facebook.com/intern/diff/D16987936)
suo
added a commit
that referenced
this pull request
Aug 30, 2019
Previously, when the tracer encountered a scripted function (or method), it inlined the function into the graph. Now, we emit a CallFunction or CallMethod node instead. ghstack-source-id: b4ef95e3f8f408c094d553597332fe4d1b9f4a96 Pull Request resolved: #25089
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Previously, when the tracer encountered a scripted function (or method), it
inlined the function into the graph. Now, we emit a CallFunction or
CallMethod node instead.
Differential Revision: D16987936