Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytorch 1.3 graph #26639

Closed
wants to merge 4 commits into from
Closed

pytorch 1.3 graph #26639

wants to merge 4 commits into from

Conversation

lanpa
Copy link
Collaborator

@lanpa lanpa commented Sep 23, 2019

This patch fixes the problem that the rendered graph is not meaningful.

Since pytorch 1.2, the representation of the traced graph has changed alot, which includes:

  1. Many operators were added.
  2. The parameter node is moved to graph.nodes(), rather than graph.inputs()
  3. The graph is been traced in detail. Take convolution for example, the traced result looks like
    aten::_convolution(%input.5, %weight.2, %7, %66, %69, %72, %73, %76, %77, %78, %79, %80)
    Besides input, weight, and bias, other nodes are parameters such as stride, kernel size, etc. This information are encoded as "attributes" before.

cc @orionr @sanekmelnikov

@orionr
Copy link
Contributor

orionr commented Oct 30, 2019

@sanekmelnikov and @lanpa, can we try and land this before the PyTorch 1.4 release cut on 11/19?

@orionr
Copy link
Contributor

orionr commented Oct 30, 2019

Also, @lanpa, can you include a before and after visualization for this so we can see what changed/improved?

@orionr
Copy link
Contributor

orionr commented Oct 30, 2019

Also, @lanpa, can you include a before and after visualization for this so we can see what changed/improved? cc @J0Nreynolds @natalialunova

@lanpa
Copy link
Collaborator Author

lanpa commented Oct 31, 2019

@orionr @sanekmelnikov Here are two side by side comparision on whether applying c934d7a or not. And the zip file contains the event files that can be visualized in TB.
Archive.zip
Screen Shot 2019-10-31 at 10 20 48 PM

fig.1 The pink arrow indicates the output node of the graph.

Screen Shot 2019-10-31 at 10 22 57 PM

*fig.2 The figure shows the inside of a convolutional layer. The right one contains all of the nodes I mentioned in the PR description, while the left is the simplified graph (point #3) *

@lanpa
Copy link
Collaborator Author

lanpa commented Mar 14, 2020

Close since v1.3 is legacy.

@lanpa lanpa closed this Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants