PEP8

[bartvm]

I have an unhealthy obsession with PEP8... Could viewAs, expandAs be renamed to view_as, expand_as, etc.?

I might even volunteer to make everything pass flake8 if you guys are okay with accepting a PR that does that.

[soumith]

If that's REALLY the convention, I'm okay with it. Though it looks uglier ;-)
@apaszke wdyt?

[apaszke]

I think it's best to stick with PEP8. However, this will also require changing index*, masked* and possibly some other methods.
Also, it would be nice to set up a linter.

[colesbury]

@apaszke, if you use Atom you get Facebook's linter which seems to be PEP8 compatible.

One thing I noticed is that this apparently isn't accepted style in Python:

# Arguments on first line forbidden when not using vertical alignment.
foo = long_function_name(var_one, var_two,
    var_three, var_four)

Instead the preferred style is:

# Hanging indents should add a level.
foo = long_function_name(
    var_one, var_two,
    var_three, var_four)

or

foo = long_function_name(var_one, var_two,
                         var_three, var_four)

[apaszke]

We should probably set up pylint and make it run at each pull request. This way we can slowly make ourselves more pep8 compliant and eventually we'll just go over the whole codebase and fix all errors. I'm using vim, I'll get myself some linter plugin tomorrow.

[ebetica]

Can we get rid of "import *" statements as well? Not PEP8 but lots of people seem annoyed at it.

http://stackoverflow.com/questions/2386714/why-is-import-bad