-
Notifications
You must be signed in to change notification settings - Fork 22.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add C++ torch::nn::functional::affine_grid #27263
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for your help @jon-tow! My apologies that I was on vacation last week and didn't review the PR soon enough. I left some very minor comments.
Thanks for the help @yf225. Hope you enjoyed your vacation! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jon-tow Thanks a lot and it looks awesome! I will merge it today :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yf225 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@pytorchbot rebase this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yf225 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Adds`torch::nn::functional::affine_grid` functional support for the C++ API. Issue: pytorch#25883, pytorch#27196 Reviewer: yf225 Pull Request resolved: pytorch#27263 Differential Revision: D17802350 Pulled By: yf225 fbshipit-source-id: e823ee53da4a4cc6a1650d2dfc09b0ef6a74e249
Adds
torch::nn::functional::affine_grid
functional support for the C++ API.Issue: #25883, #27196
Reviewer: @yf225