Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add C++ torch::nn::functional::affine_grid #27263

Closed
wants to merge 11 commits into from

Conversation

jon-tow
Copy link
Contributor

@jon-tow jon-tow commented Oct 3, 2019

Addstorch::nn::functional::affine_grid functional support for the C++ API.

Issue: #25883, #27196

Reviewer: @yf225

@pytorchbot pytorchbot added the module: cpp Related to C++ API label Oct 3, 2019
Copy link
Contributor

@yf225 yf225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your help @jon-tow! My apologies that I was on vacation last week and didn't review the PR soon enough. I left some very minor comments.

torch/csrc/api/include/torch/nn/functional/vision.h Outdated Show resolved Hide resolved
torch/csrc/api/include/torch/nn/functional/vision.h Outdated Show resolved Hide resolved
torch/csrc/api/include/torch/nn/functional/vision.h Outdated Show resolved Hide resolved
torch/csrc/api/include/torch/nn/functional/vision.h Outdated Show resolved Hide resolved
torch/csrc/api/include/torch/nn/functional/vision.h Outdated Show resolved Hide resolved
torch/csrc/api/include/torch/nn/functional/vision.h Outdated Show resolved Hide resolved
torch/csrc/api/include/torch/nn/functional/vision.h Outdated Show resolved Hide resolved
torch/csrc/api/include/torch/nn/functional/vision.h Outdated Show resolved Hide resolved
torch/csrc/api/include/torch/nn/functional/vision.h Outdated Show resolved Hide resolved
@jon-tow
Copy link
Contributor Author

jon-tow commented Oct 7, 2019

Thanks for the help @yf225. Hope you enjoyed your vacation!
I believe I've covered everything, but please let me know otherwise :).

Copy link
Contributor

@yf225 yf225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jon-tow Thanks a lot and it looks awesome! I will merge it today :D

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yf225 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@yf225
Copy link
Contributor

yf225 commented Oct 8, 2019

@pytorchbot rebase this please

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yf225 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@jon-tow jon-tow deleted the c++-api/affine-grid branch October 10, 2019 06:20
@facebook-github-bot
Copy link
Contributor

@yf225 merged this pull request in f3df6b8.

thiagocrepaldi pushed a commit to thiagocrepaldi/pytorch that referenced this pull request Feb 4, 2020
Summary:
Adds`torch::nn::functional::affine_grid` functional support for the C++ API.

Issue: pytorch#25883, pytorch#27196

Reviewer: yf225
Pull Request resolved: pytorch#27263

Differential Revision: D17802350

Pulled By: yf225

fbshipit-source-id: e823ee53da4a4cc6a1650d2dfc09b0ef6a74e249
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants