Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LayerNorm Bug #28196

Closed
wants to merge 1 commit into from
Closed

Conversation

xiaomengy
Copy link
Contributor

Summary: Fix LayerNorm Bug

Test Plan: buck test mode/dev-nosan caffe2/test:nn -- "LayerNorm"

Differential Revision: D17973451

Summary: Fix LayerNorm Bug

Test Plan: buck test mode/dev-nosan caffe2/test:nn -- "LayerNorm"

Differential Revision: D17973451

fbshipit-source-id: 8d6137bf1275ef578d9adf057b4681a2cb571de9
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D17973451

@xiaomengy xiaomengy requested a review from ngimel October 17, 2019 02:34
Copy link
Collaborator

@ngimel ngimel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's land this, but please add the tests. Also, doing at::empty_like(gamma) with the proper dtype will make code more readable.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in d083b44.

zdevito pushed a commit to zdevito/ATen that referenced this pull request Oct 17, 2019
Summary:
Pull Request resolved: pytorch/pytorch#28196

Fix LayerNorm Bug

Test Plan: buck test mode/dev-nosan caffe2/test:nn -- "LayerNorm"

Reviewed By: okhonko, houseroad

Differential Revision: D17973451

fbshipit-source-id: 865e4f295b8d6c0438ec8872da0b43d3c5d3d3c6
thiagocrepaldi pushed a commit to thiagocrepaldi/pytorch that referenced this pull request Feb 4, 2020
Summary:
Pull Request resolved: pytorch#28196

Fix LayerNorm Bug

Test Plan: buck test mode/dev-nosan caffe2/test:nn -- "LayerNorm"

Reviewed By: okhonko, houseroad

Differential Revision: D17973451

fbshipit-source-id: 865e4f295b8d6c0438ec8872da0b43d3c5d3d3c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants