Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off scalar_check for _th_normal. #29955

Closed
wants to merge 8 commits into from

Conversation

gchanan
Copy link
Contributor

@gchanan gchanan commented Nov 16, 2019

Stack from ghstack:

Differential Revision: D18548051

@gchanan gchanan requested a review from albanD November 26, 2019 21:39
@gchanan gchanan changed the title [WIP] Turn off scalar_check for _th_normal. Turn off scalar_check for _th_normal. Nov 26, 2019
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we still mark this as BC-breaking even though it's very minor?

@gchanan
Copy link
Contributor Author

gchanan commented Nov 27, 2019

@albanD good question. In this case it's very clearly a bug and CPU did the right thing, so it doesn't seem more BC breaking than any other bug fix that people may rely on.

@facebook-github-bot facebook-github-bot deleted the gh/gchanan/138/head branch December 10, 2019 15:18
wuhuikx pushed a commit to wuhuikx/pytorch that referenced this pull request Jan 30, 2020
Summary: Pull Request resolved: pytorch#29955

Test Plan: Imported from OSS

Differential Revision: D18548051

Pulled By: gchanan

fbshipit-source-id: c652999ac9e37d2592aa85ef022040fe0700b5cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants