-
Notifications
You must be signed in to change notification settings - Fork 22.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn off scalar_check for _th_normal. #29955
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced Nov 16, 2019
Differential Revision: [D18548051](https://our.internmc.facebook.com/intern/diff/D18548051) [ghstack-poisoned]
gchanan
added a commit
that referenced
this pull request
Nov 16, 2019
ghstack-source-id: 49fcdcbfd16e701d03fc115e838272aeabbaa856 Pull Request resolved: #29955
This was referenced Nov 25, 2019
Differential Revision: [D18548051](https://our.internmc.facebook.com/intern/diff/D18548051) [ghstack-poisoned]
Differential Revision: [D18548051](https://our.internmc.facebook.com/intern/diff/D18548051) [ghstack-poisoned]
Differential Revision: [D18548051](https://our.internmc.facebook.com/intern/diff/D18548051) [ghstack-poisoned]
Differential Revision: [D18548051](https://our.internmc.facebook.com/intern/diff/D18548051) [ghstack-poisoned]
Differential Revision: [D18548051](https://our.internmc.facebook.com/intern/diff/D18548051) [ghstack-poisoned]
gchanan
changed the title
[WIP] Turn off scalar_check for _th_normal.
Turn off scalar_check for _th_normal.
Nov 26, 2019
albanD
approved these changes
Nov 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we still mark this as BC-breaking even though it's very minor?
Differential Revision: [D18548051](https://our.internmc.facebook.com/intern/diff/D18548051) [ghstack-poisoned]
@albanD good question. In this case it's very clearly a bug and CPU did the right thing, so it doesn't seem more BC breaking than any other bug fix that people may rely on. |
wuhuikx
pushed a commit
to wuhuikx/pytorch
that referenced
this pull request
Jan 30, 2020
Summary: Pull Request resolved: pytorch#29955 Test Plan: Imported from OSS Differential Revision: D18548051 Pulled By: gchanan fbshipit-source-id: c652999ac9e37d2592aa85ef022040fe0700b5cf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D18548051