Add more details to explain rpc_backend_options arg in init_rpc #30855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
mrshenli
requested review from
pritamdamania87 and
zhaojuanmao
as code owners
This was referenced Dec 6, 2019
|
screen shot is on the topmost PR |
zhaojuanmao
approved these changes
Dec 6, 2019
rohan-varma
approved these changes
Dec 6, 2019
There was a problem hiding this comment.
Thanks, this will help resolve issue #30287. We should probably also add the docs for the data structure in the pybind layer, I was planning to get to that shortly.
wuhuikx
pushed a commit
to wuhuikx/pytorch
that referenced
this pull request
Jan 30, 2020
Summary: Pull Request resolved: pytorch#30855 Test Plan: Imported from OSS Differential Revision: D18847529 Pulled By: mrshenli fbshipit-source-id: b4f0d5797f3b41cce155b7821d6bd34b268bd24e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D18847529