Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove c++14-conditional constexpr #30916

Closed
wants to merge 8 commits into from

Conversation

smessmer
Copy link
Contributor

@smessmer smessmer commented Dec 7, 2019

Stack from ghstack:

These macros said "make it constexpr if we're in C++14". Since we're now always C++14, we can just say "constexpr" isntead.

Differential Revision: D18869635

These macros said "make it constexpr if we're in C++14". Since we're now always C++14, we can just say "constexpr" isntead.

Differential Revision: [D18869635](https://our.internmc.facebook.com/intern/diff/D18869635/)

[ghstack-poisoned]
These macros said "make it constexpr if we're in C++14". Since we're now always C++14, we can just say "constexpr" isntead.

Differential Revision: [D18869635](https://our.internmc.facebook.com/intern/diff/D18869635/)

[ghstack-poisoned]
These macros said "make it constexpr if we're in C++14". Since we're now always C++14, we can just say "constexpr" isntead.

Differential Revision: [D18869635](https://our.internmc.facebook.com/intern/diff/D18869635/)

[ghstack-poisoned]
These macros said "make it constexpr if we're in C++14". Since we're now always C++14, we can just say "constexpr" isntead.

Differential Revision: [D18869635](https://our.internmc.facebook.com/intern/diff/D18869635/)

[ghstack-poisoned]
These macros said "make it constexpr if we're in C++14". Since we're now always C++14, we can just say "constexpr" isntead.

Differential Revision: [D18869635](https://our.internmc.facebook.com/intern/diff/D18869635/)

[ghstack-poisoned]
smessmer added a commit that referenced this pull request Dec 10, 2019
Pull Request resolved: #30916

These macros said "make it constexpr if we're in C++14". Since we're now always C++14, we can just say "constexpr" isntead.
ghstack-source-id: 95255795

Differential Revision: [D18869635](https://our.internmc.facebook.com/intern/diff/D18869635/)
These macros said "make it constexpr if we're in C++14". Since we're now always C++14, we can just say "constexpr" isntead.

Differential Revision: [D18869635](https://our.internmc.facebook.com/intern/diff/D18869635/)

[ghstack-poisoned]
smessmer added a commit that referenced this pull request Dec 17, 2019
Pull Request resolved: #30916

These macros said "make it constexpr if we're in C++14". Since we're now always C++14, we can just say "constexpr" isntead.
ghstack-source-id: 95811559

Differential Revision: [D18869635](https://our.internmc.facebook.com/intern/diff/D18869635/)
@kostmo
Copy link
Member

kostmo commented Dec 17, 2019

💊 CircleCI build failures summary and remediations

As of commit d55783f:

None of the build failures appear to be your fault.

  • 1/1 broken upstream at merge base 22044c6 since Jan 07

    You may want to rebase on the viable/strict branch (expand for instructions)

    If your commit is newer than viable/strict, you can try basing on an older, stable commit:

    git fetch origin viable/strict
    git rebase --onto viable/strict $(git merge-base origin/master HEAD)
    

    If your commit is older than viable/strict:

    git fetch origin viable/strict
    git rebase viable/strict
    

    Check out the recency history of this "viable master" tracking branch.


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 7 times.

These macros said "make it constexpr if we're in C++14". Since we're now always C++14, we can just say "constexpr" isntead.

Differential Revision: [D18869635](https://our.internmc.facebook.com/intern/diff/D18869635/)

[ghstack-poisoned]
smessmer added a commit that referenced this pull request Dec 17, 2019
Pull Request resolved: #30916

These macros said "make it constexpr if we're in C++14". Since we're now always C++14, we can just say "constexpr" isntead.
ghstack-source-id: 95855443

Differential Revision: [D18869635](https://our.internmc.facebook.com/intern/diff/D18869635/)
These macros said "make it constexpr if we're in C++14". Since we're now always C++14, we can just say "constexpr" isntead.

Differential Revision: [D18869635](https://our.internmc.facebook.com/intern/diff/D18869635/)

[ghstack-poisoned]
smessmer added a commit that referenced this pull request Jan 7, 2020
Pull Request resolved: #30916

These macros said "make it constexpr if we're in C++14". Since we're now always C++14, we can just say "constexpr" isntead.
ghstack-source-id: 96369584

Differential Revision: [D18869635](https://our.internmc.facebook.com/intern/diff/D18869635/)
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in c21f899.

@facebook-github-bot facebook-github-bot deleted the gh/smessmer/134/head branch January 12, 2020 15:17
wuhuikx pushed a commit to wuhuikx/pytorch that referenced this pull request Jan 30, 2020
Summary:
Pull Request resolved: pytorch#30916

These macros said "make it constexpr if we're in C++14". Since we're now always C++14, we can just say "constexpr" isntead.
ghstack-source-id: 96369584

Test Plan: waitforsandcastle

Differential Revision: D18869635

fbshipit-source-id: f41751e4e26fad6214ec3a98db2d961315fd73ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants