-
Notifications
You must be signed in to change notification settings - Fork 22.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove c++14-conditional constexpr #30916
Conversation
These macros said "make it constexpr if we're in C++14". Since we're now always C++14, we can just say "constexpr" isntead. Differential Revision: [D18869635](https://our.internmc.facebook.com/intern/diff/D18869635/) [ghstack-poisoned]
These macros said "make it constexpr if we're in C++14". Since we're now always C++14, we can just say "constexpr" isntead. Differential Revision: [D18869635](https://our.internmc.facebook.com/intern/diff/D18869635/) [ghstack-poisoned]
These macros said "make it constexpr if we're in C++14". Since we're now always C++14, we can just say "constexpr" isntead. Differential Revision: [D18869635](https://our.internmc.facebook.com/intern/diff/D18869635/) [ghstack-poisoned]
These macros said "make it constexpr if we're in C++14". Since we're now always C++14, we can just say "constexpr" isntead. Differential Revision: [D18869635](https://our.internmc.facebook.com/intern/diff/D18869635/) [ghstack-poisoned]
These macros said "make it constexpr if we're in C++14". Since we're now always C++14, we can just say "constexpr" isntead. Differential Revision: [D18869635](https://our.internmc.facebook.com/intern/diff/D18869635/) [ghstack-poisoned]
Pull Request resolved: #30916 These macros said "make it constexpr if we're in C++14". Since we're now always C++14, we can just say "constexpr" isntead. ghstack-source-id: 95255795 Differential Revision: [D18869635](https://our.internmc.facebook.com/intern/diff/D18869635/)
These macros said "make it constexpr if we're in C++14". Since we're now always C++14, we can just say "constexpr" isntead. Differential Revision: [D18869635](https://our.internmc.facebook.com/intern/diff/D18869635/) [ghstack-poisoned]
Pull Request resolved: #30916 These macros said "make it constexpr if we're in C++14". Since we're now always C++14, we can just say "constexpr" isntead. ghstack-source-id: 95811559 Differential Revision: [D18869635](https://our.internmc.facebook.com/intern/diff/D18869635/)
💊 CircleCI build failures summary and remediationsAs of commit d55783f: None of the build failures appear to be your fault.
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 7 times. |
These macros said "make it constexpr if we're in C++14". Since we're now always C++14, we can just say "constexpr" isntead. Differential Revision: [D18869635](https://our.internmc.facebook.com/intern/diff/D18869635/) [ghstack-poisoned]
Pull Request resolved: #30916 These macros said "make it constexpr if we're in C++14". Since we're now always C++14, we can just say "constexpr" isntead. ghstack-source-id: 95855443 Differential Revision: [D18869635](https://our.internmc.facebook.com/intern/diff/D18869635/)
These macros said "make it constexpr if we're in C++14". Since we're now always C++14, we can just say "constexpr" isntead. Differential Revision: [D18869635](https://our.internmc.facebook.com/intern/diff/D18869635/) [ghstack-poisoned]
Pull Request resolved: #30916 These macros said "make it constexpr if we're in C++14". Since we're now always C++14, we can just say "constexpr" isntead. ghstack-source-id: 96369584 Differential Revision: [D18869635](https://our.internmc.facebook.com/intern/diff/D18869635/)
This pull request has been merged in c21f899. |
Summary: Pull Request resolved: pytorch#30916 These macros said "make it constexpr if we're in C++14". Since we're now always C++14, we can just say "constexpr" isntead. ghstack-source-id: 96369584 Test Plan: waitforsandcastle Differential Revision: D18869635 fbshipit-source-id: f41751e4e26fad6214ec3a98db2d961315fd73ff
Stack from ghstack:
These macros said "make it constexpr if we're in C++14". Since we're now always C++14, we can just say "constexpr" isntead.
Differential Revision: D18869635