-
Notifications
You must be signed in to change notification settings - Fork 22.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[profiler] add enabled API to autograd profiler #31380
Conversation
For being able to profile async RPCs, we attach a `RecordFunction` object to the future that is created during the RPC to persist it across the lifetime of the RPC (this is implemented in the next PR: ). Since we'd only like to do this when profiling is enabled, this PR adds an enabled API to the autograd profiler. Differential Revision: [D19050391](https://our.internmc.facebook.com/intern/diff/D19050391/) [ghstack-poisoned]
Don't we already check if the profiler is enabled in #31381 and attach the RecordFunction only in those cases? Otherwise the rf_ pointer is nullptr? |
@pritamdamania87 : That check relies on this change, in particular, it uses |
For being able to profile async RPCs, we attach a `RecordFunction` object to the future that is created during the RPC to persist it across the lifetime of the RPC (this is implemented in the next PR:#31381 ). Since we'd only like to do this when profiling is enabled, this PR adds an enabled API to the autograd profiler. Differential Revision: [D19050391](https://our.internmc.facebook.com/intern/diff/D19050391/) [ghstack-poisoned]
Pull Request resolved: #31380 For being able to profile async RPCs, we attach a `RecordFunction` object to the future that is created during the RPC to persist it across the lifetime of the RPC (this is implemented in the next PR: ). Since we'd only like to do this when profiling is enabled, this PR adds an enabled API to the autograd profiler. ghstack-source-id: 96040035 Differential Revision: [D19050391](https://our.internmc.facebook.com/intern/diff/D19050391/)
💊 CircleCI build failures summary and remediationsAs of commit 9b40a7e:
Detailed failure analysisOne may explore the probable reasons each build failed interactively on the Dr. CI website. 🕵️ 1 new failure recognized by patternsThe following build failures don't appear to be due to upstream breakage: caffe2_onnx_py2_gcc5_ubuntu16_04_test (1/1)Step: "Test" (full log | pattern match details)
|
For being able to profile async RPCs, we attach a `RecordFunction` object to the future that is created during the RPC to persist it across the lifetime of the RPC (this is implemented in the next PR:#31381 ). Since we'd only like to do this when profiling is enabled, this PR adds an enabled API to the autograd profiler. Differential Revision: [D19050391](https://our.internmc.facebook.com/intern/diff/D19050391/) [ghstack-poisoned]
Pull Request resolved: #31380 For being able to profile async RPCs, we attach a `RecordFunction` object to the future that is created during the RPC to persist it across the lifetime of the RPC (this is implemented in the next PR: ). Since we'd only like to do this when profiling is enabled, this PR adds an enabled API to the autograd profiler. ghstack-source-id: 96053933 Differential Revision: [D19050391](https://our.internmc.facebook.com/intern/diff/D19050391/)
Test failures are unrelated:
and
|
This pull request has been merged in cc2d5ca. |
Summary: Pull Request resolved: pytorch#31380 For being able to profile async RPCs, we attach a `RecordFunction` object to the future that is created during the RPC to persist it across the lifetime of the RPC (this is implemented in the next PR: ). Since we'd only like to do this when profiling is enabled, this PR adds an enabled API to the autograd profiler. ghstack-source-id: 96053933 Test Plan: Modified unit test. Differential Revision: D19050391 fbshipit-source-id: aa382110e69d06b4a84c83b31d2bec2d8a81ba10
Stack from ghstack:
For being able to profile async RPCs, we attach a
RecordFunction
object to the future that is created during the RPC to persist it across the lifetime of the RPC (this is implemented in the next PR:#31381 ). Since we'd only like to do this when profiling is enabled, this PR adds an enabled API to the autograd profiler.Differential Revision: D19050391