Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure temporary vectors are properly initialized in avx2 code #32722

Closed
wants to merge 2 commits into from

Conversation

albanD
Copy link
Collaborator

@albanD albanD commented Jan 28, 2020

Stack from ghstack:

Fix #32502
Checked using this that it gives the correct assembly.

Differential Revision: D19610012

albanD added a commit that referenced this pull request Jan 28, 2020
ghstack-source-id: 45718cf4d0b9b16e16216db3ed087d7506a71683
Pull Request resolved: #32722
…x2 code"


Checked using [this](https://godbolt.org/z/uAaE9R) that it gives the correct assembly.

[ghstack-poisoned]
albanD added a commit that referenced this pull request Jan 28, 2020
ghstack-source-id: 4f91f2f6b433d7fb2131695eae52e0978cfd0937
Pull Request resolved: #32722
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yey

wuhuikx pushed a commit to wuhuikx/pytorch that referenced this pull request Jan 30, 2020
…torch#32722)

Summary:
Pull Request resolved: pytorch#32722

Checked using [this](https://godbolt.org/z/uAaE9R) that it gives the correct assembly.

Test Plan: Imported from OSS

Differential Revision: D19610012

Pulled By: albanD

fbshipit-source-id: 4d1cb812951ae03d412a0fba3c80730f0d286e1f
@facebook-github-bot
Copy link
Contributor

@albanD merged this pull request in 594cade.

@facebook-github-bot facebook-github-bot deleted the gh/albanD/30/head branch February 2, 2020 15:17
ttumiel pushed a commit to ttumiel/pytorch that referenced this pull request Mar 4, 2020
…torch#32722)

Summary:
Pull Request resolved: pytorch#32722

Checked using [this](https://godbolt.org/z/uAaE9R) that it gives the correct assembly.

Test Plan: Imported from OSS

Differential Revision: D19610012

Pulled By: albanD

fbshipit-source-id: 4d1cb812951ae03d412a0fba3c80730f0d286e1f
xuhdev added a commit that referenced this pull request Mar 5, 2020
…ly initialized

Seems like #32722 has missed two loadu functions

[ghstack-poisoned]
xuhdev added a commit that referenced this pull request Mar 5, 2020
… are properly initialized"

Seems like #32722 has missed two loadu functions

[ghstack-poisoned]
xuhdev added a commit that referenced this pull request Mar 5, 2020
…ly initialized

Seems like #32722 has missed two loadu functions

ghstack-source-id: 5ecc7c5ade646a3001fd09c0cd87c7456fdf0bb9
Pull Request resolved: #34281
xuhdev added a commit that referenced this pull request Mar 5, 2020
… are properly initialized"

Seems like #32722 has missed two loadu functions

[ghstack-poisoned]
xuhdev added a commit that referenced this pull request Mar 5, 2020
… are properly initialized"

Seems like #32722 has missed two loadu functions

[ghstack-poisoned]
xuhdev added a commit that referenced this pull request Mar 5, 2020
…ly initialized

Seems like #32722 has missed two loadu functions

ghstack-source-id: 80f5f5278afaf9bb958982caea2bea549403698f
Pull Request resolved: #34281
facebook-github-bot pushed a commit that referenced this pull request Mar 6, 2020
…ly initialized (#34281)

Summary:
Pull Request resolved: #34281

Seems like #32722 has missed two loadu functions

Test Plan: Imported from OSS

Differential Revision: D20287731

Pulled By: albanD

fbshipit-source-id: d959b2508de3f9f660368152d7260026d7fbccbe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants