-
Notifications
You must be signed in to change notification settings - Fork 22.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make tests for empty inputs check zero parameter grads #32820
Conversation
💊 CircleCI build failures summary and remediationsAs of commit bec1e35: None of the build failures appear to be your fault.
Detailed failure analysisOne may explore the probable reasons each build failed interactively on the Dr. CI website. 🚧 2 upstream failures recognized by patterns:These builds matched patterns, but were probably caused by upstream breakages:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 5 times. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're missing the test for batchnorm no?
Otherwise looks good.
Tests for batch norm were already present, they just did not check parameter gradients. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right I was confused because you add a test for convtranspose :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Transition to native pytorch support that's recently added: pytorch/pytorch#32709 adds support for conv/convtranspose. pytorch/pytorch#32820 adds support for batchnorm. pytorch/pytorch#32401 adds support for groupnorm. Reviewed By: rbgirshick Differential Revision: D19658831 fbshipit-source-id: 48834996809b28bdaa6ab6930676a0d54a492460
Summary: Make batch norm with empty inputs return zero parameter gradients. Now batch norm, group norm and convolutions now return zero grads for parameters, so make tests check that. Fixes some bullet points in pytorch#12013 (interpolate is not fixed by this PR, is being fixed in other PRs) Pull Request resolved: pytorch#32820 Differential Revision: D19651470 Pulled By: ngimel fbshipit-source-id: 96fdd085f9b0e98e91217dd2ac1f30f9c482b8be
Make batch norm with empty inputs return zero parameter gradients. Now batch norm, group norm and convolutions now return zero grads for parameters, so make tests check that. Fixes some bullet points in #12013 (interpolate is not fixed by this PR, is being fixed in other PRs)