Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.5.0] Fixes default dtype value for onnx hardtanh export (opset11) (#35467) #36184

Closed
wants to merge 1 commit into from

Conversation

gchanan
Copy link
Contributor

@gchanan gchanan commented Apr 7, 2020

Summary:
Oneline fix to lara-hdr 's PR #30169.

Default dtype value should be set when dtype is None rather than when dtype is not None.

I didn't make an issue for this as such a small change but I have been using this locally in order to export a model with opset 11 (opset 10 still works).
Pull Request resolved: #35467

Differential Revision: D20686048

Pulled By: mruberry

fbshipit-source-id: 726a5f9c0711c7a79b171fe98b602cdef27f9b31

…#35467)

Summary:
Oneline fix to lara-hdr 's PR pytorch#30169.

Default `dtype` value should be set when `dtype is None` rather than when `dtype is not None`.

I didn't make an issue for this as such a small change but I have been using this locally in order to export a model with opset 11 (opset 10 still works).
Pull Request resolved: pytorch#35467

Differential Revision: D20686048

Pulled By: mruberry

fbshipit-source-id: 726a5f9c0711c7a79b171fe98b602cdef27f9b31
@dr-ci
Copy link

dr-ci bot commented Apr 7, 2020

💊 CircleCI build failures summary and remediations

As of commit 6c519a1 (more details on the Dr. CI page):


  • 2/2 failures introduced in this PR

🕵️ 2 new failures recognized by patterns

The following build failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_cpp_doc_push (1/2)

Step: "Doc Build and Push" (full log | pattern match details | 🔁 rerun) <confirmed not flaky by 2 failures>

Apr 08 00:26:46 AttributeError: module 'sphinx.domains.c' has no attribute 'CMacroObject'
Apr 08 00:26:44     Found existing installation: Sphinx 3.0.0 
Apr 08 00:26:44     Uninstalling Sphinx-3.0.0: 
Apr 08 00:26:44       Successfully uninstalled Sphinx-3.0.0 
Apr 08 00:26:45 Successfully installed sphinx-2.4.4 
Apr 08 00:26:45 ++ make VERBOSE=1 html -j 
Apr 08 00:26:46 Running Sphinx v2.4.4 
Apr 08 00:26:46  
Apr 08 00:26:46 Exception occurred: 
Apr 08 00:26:46   File "/opt/conda/lib/python3.6/site-packages/breathe/renderer/sphinxrenderer.py", line 90, in DomainDirectiveFactory 
Apr 08 00:26:46     'define': (c.CMacroObject, 'macro'), 
Apr 08 00:26:46 AttributeError: module 'sphinx.domains.c' has no attribute 'CMacroObject' 
Apr 08 00:26:46 The full traceback has been saved in /tmp/sphinx-err-4ij3nz_2.log, if you want to report the issue to the developers. 
Apr 08 00:26:46 Please also report this if it was a user error, so that a better error message can be provided next time. 
Apr 08 00:26:46 A bug report can be filed in the tracker at <https://github.com/sphinx-doc/sphinx/issues>. Thanks! 
Apr 08 00:26:46 Makefile:27: recipe for target 'html' failed 
Apr 08 00:26:46 make: *** [html] Error 2 

See CircleCI build pytorch_windows_vs2019_py36_cuda10.1_build (2/2)

Step: "Build" (full log | pattern match details | 🔁 rerun) <confirmed not flaky by 2 failures>

ERROR: The process "sccache.exe" not found.
curl --retry 3 -k https://s3.amazonaws.com/ossci-windows/sccache.exe --output C:\Users\circleci\project\build\win_tmp\bin\sccache.exe   
 curl --retry 3 -k https://s3.amazonaws.com/ossci-windows/sccache-cl.exe --output C:\Users\circleci\project\build\win_tmp\bin\sccache-cl.exe  
)  else ( 
aws s3 cp s3://ossci-windows/sccache.exe C:\Users\circleci\project\build\win_tmp\bin\sccache.exe   
 aws s3 cp s3://ossci-windows/sccache-cl.exe C:\Users\circleci\project\build\win_tmp\bin\sccache-cl.exe  
)   
 goto :check_sccache  
) )  
'C:\Users\circleci\project\build\win_tmp\bin\sccache.exe' is not recognized as an internal or external command, 
operable program or batch file. 
ERROR: The process "sccache.exe" not found. 
Could Not Find C:\Users\circleci\project\build\win_tmp\bin\sccache.exe 
Could Not Find C:\Users\circleci\project\build\win_tmp\bin\sccache-cl.exe 
Completed 5.0 MiB/5.3 MiB (20.3 MiB/s) with 1 file(s) remaining  Completed 5.2 MiB/5.3 MiB (21.2 MiB/s) with 1 file(s) remaining  Completed 5.3 MiB/5.3 MiB (21.3 MiB/s) with 1 file(s) remaining  download: s3://ossci-windows/sccache.exe to build\win_tmp\bin\sccache.exe 
Completed 25.0 KiB/25.0 KiB (228.6 KiB/s) with 1 file(s) remaining download: s3://ossci-windows/sccache-cl.exe to build\win_tmp\bin\sccache-cl.exe 
 
circleci@PACKER-5E70C994 C:\Users\circleci\project>C:\Users\circleci\project\build\win_tmp\bin\sccache.exe --show-stats   || ( 
taskkill /im sccache.exe /f /t   || ver  1>nul   
 del C:\Users\circleci\project\build\win_tmp\bin\sccache.exe   || ver  1>nul   
 del C:\Users\circleci\project\build\win_tmp\bin\sccache-cl.exe   || ver  1>nul   
 if "pytorch-win-ws2019-cuda10-cudnn7-py3" == "" ( 

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 3 times.

@gchanan gchanan closed this Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants