Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unconditionally register schema even for manual registration. #36250

Closed
wants to merge 11 commits into from

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented Apr 8, 2020

Stack from ghstack:

The general concept is that I want a centralized location where you
can find all of the registrations for a library. I cannot do this
if I don't codegen all of the schemas in one spot--right now,
most schemas get generated, but not manually registered ones. Let us
assume that manual registration has to do with the actual
implementations; nothing strange is going on with the schema
definition itself. Make it so.

Signed-off-by: Edward Z. Yang ezyang@fb.com

Differential Revision: D20929258

The general concept is that I want a centralized location where you
can find all of the registrations for a library.  I cannot do this
if I don't codegen all of the schemas in one spot--right now,
most schemas get generated, but not manually registered ones. Let us
assume that manual registration has to do with the actual
implementations; nothing strange is going on with the schema
definition itself.  Make it so.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Apr 8, 2020
The general concept is that I want a centralized location where you
can find all of the registrations for a library.  I cannot do this
if I don't codegen all of the schemas in one spot--right now,
most schemas get generated, but not manually registered ones. Let us
assume that manual registration has to do with the actual
implementations; nothing strange is going on with the schema
definition itself.  Make it so.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

ghstack-source-id: cafa8a4187f0e2a0cafb7ddbd395857252767db0
Pull Request resolved: #36250
@dr-ci
Copy link

dr-ci bot commented Apr 8, 2020

💊 Build failures summary and remediations

As of commit fc81e9b (more details on the Dr. CI page):


None of the build failures appear to be your fault 💚


  • 1/1 broken upstream at merge base fb70b4f since Apr 14

    Please rebase on the viable/strict branch (expand for instructions)

    If your commit is newer than viable/strict, you can try basing on an older, stable commit:

    git fetch https://github.com/pytorch/pytorch viable/strict
    git rebase --onto FETCH_HEAD $(git merge-base origin/master HEAD)
    

    If your commit is older than viable/strict:

    git fetch https://github.com/pytorch/pytorch viable/strict
    git rebase FETCH_HEAD
    

    Check out the recency history of this "viable master" tracking branch.


🚧 1 upstream failure:

These were probably caused by upstream breakages:


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 32 times.

…on."

The general concept is that I want a centralized location where you
can find all of the registrations for a library.  I cannot do this
if I don't codegen all of the schemas in one spot--right now,
most schemas get generated, but not manually registered ones. Let us
assume that manual registration has to do with the actual
implementations; nothing strange is going on with the schema
definition itself.  Make it so.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

[ghstack-poisoned]
@ezyang ezyang requested review from bhosmer and smessmer April 8, 2020 22:11
…on."

The general concept is that I want a centralized location where you
can find all of the registrations for a library.  I cannot do this
if I don't codegen all of the schemas in one spot--right now,
most schemas get generated, but not manually registered ones. Let us
assume that manual registration has to do with the actual
implementations; nothing strange is going on with the schema
definition itself.  Make it so.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

Differential Revision: [D20929258](https://our.internmc.facebook.com/intern/diff/D20929258)

[ghstack-poisoned]
…on."

The general concept is that I want a centralized location where you
can find all of the registrations for a library.  I cannot do this
if I don't codegen all of the schemas in one spot--right now,
most schemas get generated, but not manually registered ones. Let us
assume that manual registration has to do with the actual
implementations; nothing strange is going on with the schema
definition itself.  Make it so.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

Differential Revision: [D20929258](https://our.internmc.facebook.com/intern/diff/D20929258)

[ghstack-poisoned]
…on."

The general concept is that I want a centralized location where you
can find all of the registrations for a library.  I cannot do this
if I don't codegen all of the schemas in one spot--right now,
most schemas get generated, but not manually registered ones. Let us
assume that manual registration has to do with the actual
implementations; nothing strange is going on with the schema
definition itself.  Make it so.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

Differential Revision: [D20929258](https://our.internmc.facebook.com/intern/diff/D20929258)

[ghstack-poisoned]
…on."

The general concept is that I want a centralized location where you
can find all of the registrations for a library.  I cannot do this
if I don't codegen all of the schemas in one spot--right now,
most schemas get generated, but not manually registered ones. Let us
assume that manual registration has to do with the actual
implementations; nothing strange is going on with the schema
definition itself.  Make it so.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

Differential Revision: [D20929258](https://our.internmc.facebook.com/intern/diff/D20929258)

[ghstack-poisoned]
…on."

The general concept is that I want a centralized location where you
can find all of the registrations for a library.  I cannot do this
if I don't codegen all of the schemas in one spot--right now,
most schemas get generated, but not manually registered ones. Let us
assume that manual registration has to do with the actual
implementations; nothing strange is going on with the schema
definition itself.  Make it so.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

Differential Revision: [D20929258](https://our.internmc.facebook.com/intern/diff/D20929258)

[ghstack-poisoned]
…on."

The general concept is that I want a centralized location where you
can find all of the registrations for a library.  I cannot do this
if I don't codegen all of the schemas in one spot--right now,
most schemas get generated, but not manually registered ones. Let us
assume that manual registration has to do with the actual
implementations; nothing strange is going on with the schema
definition itself.  Make it so.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

Differential Revision: [D20929258](https://our.internmc.facebook.com/intern/diff/D20929258)

[ghstack-poisoned]
…on."

The general concept is that I want a centralized location where you
can find all of the registrations for a library.  I cannot do this
if I don't codegen all of the schemas in one spot--right now,
most schemas get generated, but not manually registered ones. Let us
assume that manual registration has to do with the actual
implementations; nothing strange is going on with the schema
definition itself.  Make it so.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

Differential Revision: [D20929258](https://our.internmc.facebook.com/intern/diff/D20929258)

[ghstack-poisoned]
…on."

The general concept is that I want a centralized location where you
can find all of the registrations for a library.  I cannot do this
if I don't codegen all of the schemas in one spot--right now,
most schemas get generated, but not manually registered ones. Let us
assume that manual registration has to do with the actual
implementations; nothing strange is going on with the schema
definition itself.  Make it so.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

Differential Revision: [D20929258](https://our.internmc.facebook.com/intern/diff/D20929258)

[ghstack-poisoned]
…on."

The general concept is that I want a centralized location where you
can find all of the registrations for a library.  I cannot do this
if I don't codegen all of the schemas in one spot--right now,
most schemas get generated, but not manually registered ones. Let us
assume that manual registration has to do with the actual
implementations; nothing strange is going on with the schema
definition itself.  Make it so.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

Differential Revision: [D20929258](https://our.internmc.facebook.com/intern/diff/D20929258)

[ghstack-poisoned]
ljk53 pushed a commit to ljk53/pytorch that referenced this pull request Apr 14, 2020
The general concept is that I want a centralized location where you
can find all of the registrations for a library.  I cannot do this
if I don't codegen all of the schemas in one spot--right now,
most schemas get generated, but not manually registered ones. Let us
assume that manual registration has to do with the actual
implementations; nothing strange is going on with the schema
definition itself.  Make it so.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

ghstack-source-id: 2e89ed08acc9e55899ce5f83b64dd488b72e9582
Pull Request resolved: pytorch#36250
@facebook-github-bot
Copy link
Contributor

@ezyang merged this pull request in 5150334.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants