-
Notifications
You must be signed in to change notification settings - Fork 22.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unconditionally register schema even for manual registration. #36250
Conversation
The general concept is that I want a centralized location where you can find all of the registrations for a library. I cannot do this if I don't codegen all of the schemas in one spot--right now, most schemas get generated, but not manually registered ones. Let us assume that manual registration has to do with the actual implementations; nothing strange is going on with the schema definition itself. Make it so. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
The general concept is that I want a centralized location where you can find all of the registrations for a library. I cannot do this if I don't codegen all of the schemas in one spot--right now, most schemas get generated, but not manually registered ones. Let us assume that manual registration has to do with the actual implementations; nothing strange is going on with the schema definition itself. Make it so. Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: cafa8a4187f0e2a0cafb7ddbd395857252767db0 Pull Request resolved: #36250
💊 Build failures summary and remediationsAs of commit fc81e9b (more details on the Dr. CI page): ✅ None of the build failures appear to be your fault 💚
🚧 1 upstream failure:These were probably caused by upstream breakages:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 32 times. |
…on." The general concept is that I want a centralized location where you can find all of the registrations for a library. I cannot do this if I don't codegen all of the schemas in one spot--right now, most schemas get generated, but not manually registered ones. Let us assume that manual registration has to do with the actual implementations; nothing strange is going on with the schema definition itself. Make it so. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
…on." The general concept is that I want a centralized location where you can find all of the registrations for a library. I cannot do this if I don't codegen all of the schemas in one spot--right now, most schemas get generated, but not manually registered ones. Let us assume that manual registration has to do with the actual implementations; nothing strange is going on with the schema definition itself. Make it so. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D20929258](https://our.internmc.facebook.com/intern/diff/D20929258) [ghstack-poisoned]
…on." The general concept is that I want a centralized location where you can find all of the registrations for a library. I cannot do this if I don't codegen all of the schemas in one spot--right now, most schemas get generated, but not manually registered ones. Let us assume that manual registration has to do with the actual implementations; nothing strange is going on with the schema definition itself. Make it so. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D20929258](https://our.internmc.facebook.com/intern/diff/D20929258) [ghstack-poisoned]
…on." The general concept is that I want a centralized location where you can find all of the registrations for a library. I cannot do this if I don't codegen all of the schemas in one spot--right now, most schemas get generated, but not manually registered ones. Let us assume that manual registration has to do with the actual implementations; nothing strange is going on with the schema definition itself. Make it so. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D20929258](https://our.internmc.facebook.com/intern/diff/D20929258) [ghstack-poisoned]
…on." The general concept is that I want a centralized location where you can find all of the registrations for a library. I cannot do this if I don't codegen all of the schemas in one spot--right now, most schemas get generated, but not manually registered ones. Let us assume that manual registration has to do with the actual implementations; nothing strange is going on with the schema definition itself. Make it so. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D20929258](https://our.internmc.facebook.com/intern/diff/D20929258) [ghstack-poisoned]
…on." The general concept is that I want a centralized location where you can find all of the registrations for a library. I cannot do this if I don't codegen all of the schemas in one spot--right now, most schemas get generated, but not manually registered ones. Let us assume that manual registration has to do with the actual implementations; nothing strange is going on with the schema definition itself. Make it so. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D20929258](https://our.internmc.facebook.com/intern/diff/D20929258) [ghstack-poisoned]
…on." The general concept is that I want a centralized location where you can find all of the registrations for a library. I cannot do this if I don't codegen all of the schemas in one spot--right now, most schemas get generated, but not manually registered ones. Let us assume that manual registration has to do with the actual implementations; nothing strange is going on with the schema definition itself. Make it so. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D20929258](https://our.internmc.facebook.com/intern/diff/D20929258) [ghstack-poisoned]
…on." The general concept is that I want a centralized location where you can find all of the registrations for a library. I cannot do this if I don't codegen all of the schemas in one spot--right now, most schemas get generated, but not manually registered ones. Let us assume that manual registration has to do with the actual implementations; nothing strange is going on with the schema definition itself. Make it so. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D20929258](https://our.internmc.facebook.com/intern/diff/D20929258) [ghstack-poisoned]
…on." The general concept is that I want a centralized location where you can find all of the registrations for a library. I cannot do this if I don't codegen all of the schemas in one spot--right now, most schemas get generated, but not manually registered ones. Let us assume that manual registration has to do with the actual implementations; nothing strange is going on with the schema definition itself. Make it so. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D20929258](https://our.internmc.facebook.com/intern/diff/D20929258) [ghstack-poisoned]
…on." The general concept is that I want a centralized location where you can find all of the registrations for a library. I cannot do this if I don't codegen all of the schemas in one spot--right now, most schemas get generated, but not manually registered ones. Let us assume that manual registration has to do with the actual implementations; nothing strange is going on with the schema definition itself. Make it so. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D20929258](https://our.internmc.facebook.com/intern/diff/D20929258) [ghstack-poisoned]
The general concept is that I want a centralized location where you can find all of the registrations for a library. I cannot do this if I don't codegen all of the schemas in one spot--right now, most schemas get generated, but not manually registered ones. Let us assume that manual registration has to do with the actual implementations; nothing strange is going on with the schema definition itself. Make it so. Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: 2e89ed08acc9e55899ce5f83b64dd488b72e9582 Pull Request resolved: pytorch#36250
Stack from ghstack:
The general concept is that I want a centralized location where you
can find all of the registrations for a library. I cannot do this
if I don't codegen all of the schemas in one spot--right now,
most schemas get generated, but not manually registered ones. Let us
assume that manual registration has to do with the actual
implementations; nothing strange is going on with the schema
definition itself. Make it so.
Signed-off-by: Edward Z. Yang ezyang@fb.com
Differential Revision: D20929258