Make DispatchKeyExtractor forget about TensorOptions #36290
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BackendSelect dispatch key gives us a way to extract backend- specific dispatch keys from non-Tensor arguments without teaching the DispatchKeyExtractor about them. Here we finish switching over to the BackendSelect approach for factory functions and remove TensorOptions from the set of types DispatchKeyExtractor needs to consider. [ghstack-poisoned]
💊 Build failures summary and remediationsAs of commit 8c88a41 (more details on the Dr. CI page): ✅ None of the build failures appear to be your fault 💚
🚧 1 upstream failure:These were probably caused by upstream breakages:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 38 times. |
The BackendSelect dispatch key gives us a way to extract backend- specific dispatch keys from non-Tensor arguments without teaching the DispatchKeyExtractor about them. Here we finish switching over to the BackendSelect approach for factory functions and remove TensorOptions from the set of types DispatchKeyExtractor needs to consider. [ghstack-poisoned]
bhosmer
pushed a commit
that referenced
this pull request
Apr 9, 2020
The BackendSelect dispatch key gives us a way to extract backend- specific dispatch keys from non-Tensor arguments without teaching the DispatchKeyExtractor about them. Here we finish switching over to the BackendSelect approach for factory functions and remove TensorOptions from the set of types DispatchKeyExtractor needs to consider. ghstack-source-id: 25a1a8169399456805303396ae772da5c9e696c1 Pull Request resolved: #36290
The BackendSelect dispatch key gives us a way to extract backend- specific dispatch keys from non-Tensor arguments without teaching the DispatchKeyExtractor about them. Here we finish switching over to the BackendSelect approach for factory functions and remove TensorOptions from the set of types DispatchKeyExtractor needs to consider. Differential Revision: [D20936595](https://our.internmc.facebook.com/intern/diff/D20936595) [ghstack-poisoned]
The BackendSelect dispatch key gives us a way to extract backend- specific dispatch keys from non-Tensor arguments without teaching the DispatchKeyExtractor about them. Here we finish switching over to the BackendSelect approach for factory functions and remove TensorOptions from the set of types DispatchKeyExtractor needs to consider. [Codegen diff](bhosmer/scratch@before_36290...after_36290) Differential Revision: [D20936595](https://our.internmc.facebook.com/intern/diff/D20936595) [ghstack-poisoned]
The BackendSelect dispatch key gives us a way to extract backend- specific dispatch keys from non-Tensor arguments without teaching the DispatchKeyExtractor about them. Here we finish switching over to the BackendSelect approach for factory functions and remove TensorOptions from the set of types DispatchKeyExtractor needs to consider. [Codegen diff](bhosmer/scratch@before_36290...after_36290) Differential Revision: [D20936595](https://our.internmc.facebook.com/intern/diff/D20936595) [ghstack-poisoned]
bhosmer
pushed a commit
that referenced
this pull request
Apr 10, 2020
The BackendSelect dispatch key gives us a way to extract backend- specific dispatch keys from non-Tensor arguments without teaching the DispatchKeyExtractor about them. Here we finish switching over to the BackendSelect approach for factory functions and remove TensorOptions from the set of types DispatchKeyExtractor needs to consider. ghstack-source-id: 50d6f4148382b9d92a9bc0e84a7b1d113b32279a Pull Request resolved: #36290
The BackendSelect dispatch key gives us a way to extract backend- specific dispatch keys from non-Tensor arguments without teaching the DispatchKeyExtractor about them. Here we finish switching over to the BackendSelect approach for factory functions and remove TensorOptions from the set of types DispatchKeyExtractor needs to consider. [Codegen diff](bhosmer/scratch@before_36290...after_36290) Differential Revision: [D20936595](https://our.internmc.facebook.com/intern/diff/D20936595) [ghstack-poisoned]
bhosmer
pushed a commit
that referenced
this pull request
Apr 11, 2020
The BackendSelect dispatch key gives us a way to extract backend- specific dispatch keys from non-Tensor arguments without teaching the DispatchKeyExtractor about them. Here we finish switching over to the BackendSelect approach for factory functions and remove TensorOptions from the set of types DispatchKeyExtractor needs to consider. ghstack-source-id: 226481651491056a32614020aca97f55e9fc68de Pull Request resolved: #36290
The BackendSelect dispatch key gives us a way to extract backend- specific dispatch keys from non-Tensor arguments without teaching the DispatchKeyExtractor about them. Here we finish switching over to the BackendSelect approach for factory functions and remove TensorOptions from the set of types DispatchKeyExtractor needs to consider. [Codegen diff](bhosmer/scratch@before_36290...after_36290) Differential Revision: [D20936595](https://our.internmc.facebook.com/intern/diff/D20936595) [ghstack-poisoned]
The BackendSelect dispatch key gives us a way to extract backend- specific dispatch keys from non-Tensor arguments without teaching the DispatchKeyExtractor about them. Here we finish switching over to the BackendSelect approach for factory functions and remove TensorOptions from the set of types DispatchKeyExtractor needs to consider. [Codegen diff](bhosmer/scratch@before_36290...after_36290) Differential Revision: [D20936595](https://our.internmc.facebook.com/intern/diff/D20936595) [ghstack-poisoned]
bhosmer
pushed a commit
that referenced
this pull request
Apr 11, 2020
The BackendSelect dispatch key gives us a way to extract backend- specific dispatch keys from non-Tensor arguments without teaching the DispatchKeyExtractor about them. Here we finish switching over to the BackendSelect approach for factory functions and remove TensorOptions from the set of types DispatchKeyExtractor needs to consider. ghstack-source-id: 15db9483fb9dcf274573dd794bca0307c8f990dd Pull Request resolved: #36290
smessmer
approved these changes
Apr 13, 2020
aten/src/ATen/function_wrapper.py
Outdated
| @@ -509,7 +512,7 @@ def __getitem__(self, x): | |||
| 'formals': List[str], | |||
| 'formals_types': List[str], | |||
| 'formals_types_with_return': List[str], | |||
| 'inferred_key_set': str, | |||
| # 'inferred_key_set': str, | |||
The BackendSelect dispatch key gives us a way to extract backend- specific dispatch keys from non-Tensor arguments without teaching the DispatchKeyExtractor about them. Here we finish switching over to the BackendSelect approach for factory functions and remove TensorOptions from the set of types DispatchKeyExtractor needs to consider. [Codegen diff](bhosmer/scratch@before_36290...after_36290) Differential Revision: [D20936595](https://our.internmc.facebook.com/intern/diff/D20936595) [ghstack-poisoned]
bhosmer
pushed a commit
that referenced
this pull request
Apr 13, 2020
The BackendSelect dispatch key gives us a way to extract backend- specific dispatch keys from non-Tensor arguments without teaching the DispatchKeyExtractor about them. Here we finish switching over to the BackendSelect approach for factory functions and remove TensorOptions from the set of types DispatchKeyExtractor needs to consider. ghstack-source-id: c93781294a64449b222016ab6c280ca6f12d6db7 Pull Request resolved: #36290
|
Looks like this PR broke Reverting now. |
bhosmer
pushed a commit
that referenced
this pull request
Apr 14, 2020
The BackendSelect dispatch key gives us a way to extract backend- specific dispatch keys from non-Tensor arguments without teaching the DispatchKeyExtractor about them. Here we finish switching over to the BackendSelect approach for factory functions and remove TensorOptions from the set of types DispatchKeyExtractor needs to consider. [ghstack-poisoned]
bhosmer
pushed a commit
that referenced
this pull request
Apr 14, 2020
#36290)" The BackendSelect dispatch key gives us a way to extract backend- specific dispatch keys from non-Tensor arguments without teaching the DispatchKeyExtractor about them. Here we finish switching over to the BackendSelect approach for factory functions and remove TensorOptions from the set of types DispatchKeyExtractor needs to consider. Differential Revision: [D21013652](https://our.internmc.facebook.com/intern/diff/D21013652) [ghstack-poisoned]
bhosmer
pushed a commit
that referenced
this pull request
Apr 14, 2020
The BackendSelect dispatch key gives us a way to extract backend- specific dispatch keys from non-Tensor arguments without teaching the DispatchKeyExtractor about them. Here we finish switching over to the BackendSelect approach for factory functions and remove TensorOptions from the set of types DispatchKeyExtractor needs to consider. ghstack-source-id: 1b20e3b1ca8e15b6bf595b1b09960ff105cafb08 Pull Request resolved: #36562
bhosmer
pushed a commit
that referenced
this pull request
Apr 14, 2020
#36290)" The BackendSelect dispatch key gives us a way to extract backend- specific dispatch keys from non-Tensor arguments without teaching the DispatchKeyExtractor about them. Here we finish switching over to the BackendSelect approach for factory functions and remove TensorOptions from the set of types DispatchKeyExtractor needs to consider. Differential Revision: [D21013652](https://our.internmc.facebook.com/intern/diff/D21013652) [ghstack-poisoned]
bhosmer
pushed a commit
that referenced
this pull request
Apr 14, 2020
The BackendSelect dispatch key gives us a way to extract backend- specific dispatch keys from non-Tensor arguments without teaching the DispatchKeyExtractor about them. Here we finish switching over to the BackendSelect approach for factory functions and remove TensorOptions from the set of types DispatchKeyExtractor needs to consider. ghstack-source-id: 5ac9197527812bf1e74f3709896982d9984f737e Pull Request resolved: #36562
bhosmer
pushed a commit
that referenced
this pull request
Apr 15, 2020
#36290)" The BackendSelect dispatch key gives us a way to extract backend- specific dispatch keys from non-Tensor arguments without teaching the DispatchKeyExtractor about them. Here we finish switching over to the BackendSelect approach for factory functions and remove TensorOptions from the set of types DispatchKeyExtractor needs to consider. Differential Revision: [D21013652](https://our.internmc.facebook.com/intern/diff/D21013652) [ghstack-poisoned]
bhosmer
pushed a commit
that referenced
this pull request
Apr 15, 2020
The BackendSelect dispatch key gives us a way to extract backend- specific dispatch keys from non-Tensor arguments without teaching the DispatchKeyExtractor about them. Here we finish switching over to the BackendSelect approach for factory functions and remove TensorOptions from the set of types DispatchKeyExtractor needs to consider. ghstack-source-id: 3fd9d8151d2278f909c076d67e085aeb4d24db90 Pull Request resolved: #36562
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 16, 2020
…36562) Summary: Pull Request resolved: #36562 The BackendSelect dispatch key gives us a way to extract backend- specific dispatch keys from non-Tensor arguments without teaching the DispatchKeyExtractor about them. Here we finish switching over to the BackendSelect approach for factory functions and remove TensorOptions from the set of types DispatchKeyExtractor needs to consider. Test Plan: Imported from OSS Differential Revision: D21013652 Pulled By: bhosmer fbshipit-source-id: e30512d1c3202149e72b7d7ce15084bbfed63ac7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
The BackendSelect dispatch key gives us a way to extract backend-
specific dispatch keys from non-Tensor arguments without teaching
the DispatchKeyExtractor about them. Here we finish switching over
to the BackendSelect approach for factory functions and remove
TensorOptions from the set of types DispatchKeyExtractor needs to
consider.
Codegen diff
Differential Revision: D20936595