Ensure remainder of advanced indexing backwards is contiguous. #36957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is attempt to make the current master behavior the same as on 1.4. I don't know if this is more performant than just making the linearIndex contiguous. Fixes: #36956 [ghstack-poisoned]
gchanan
added a commit
that referenced
this pull request
Apr 20, 2020
…guous." This is a more straightforward solution to the problem than #36957; I don't know about the relative performance. Fixes: #36956 Differential Revision: [D21144146](https://our.internmc.facebook.com/intern/diff/D21144146) [ghstack-poisoned]
…ous." This is attempt to make the current master behavior the same as on 1.4. I don't know if this is more performant than just making the linearIndex contiguous. Fixes: #36956 Differential Revision: [D21144107](https://our.internmc.facebook.com/intern/diff/D21144107) [ghstack-poisoned]
gchanan
added a commit
to gchanan/pytorch
that referenced
this pull request
Apr 20, 2020
This is attempt to make the current master behavior the same as on 1.4. I don't know if this is more performant than just making the linearIndex contiguous. Fixes: pytorch#36956 ghstack-source-id: f5ac46a6e77dce2e82396079d2ec426953ac5966 Pull Request resolved: pytorch#36957
ngimel
approved these changes
Apr 20, 2020
gchanan
added a commit
that referenced
this pull request
Apr 20, 2020
…guous." This is a more straightforward solution to the problem than #36957; I don't know about the relative performance. Fixes: #36956 Differential Revision: [D21144146](https://our.internmc.facebook.com/intern/diff/D21144146) [ghstack-poisoned]
gchanan
added a commit
to gchanan/pytorch
that referenced
this pull request
Apr 20, 2020
…uous. This is a more straightforward solution to the problem than pytorch#36957; I don't know about the relative performance. Fixes: pytorch#36956 ghstack-source-id: 43c48eaee7232cd3ed2b108edbbee24c11e8321a Pull Request resolved: pytorch#36959
💊 Build failures summary and remediationsAs of commit 5821158 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following build failures do not appear to be due to upstream breakages:
|
gchanan
added a commit
that referenced
this pull request
Apr 20, 2020
…guous." This is a more straightforward solution to the problem than #36957; I don't know about the relative performance. Fixes: #36956 Differential Revision: [D21144146](https://our.internmc.facebook.com/intern/diff/D21144146) [ghstack-poisoned]
…ous." This is attempt to make the current master behavior the same as on 1.4. I don't know if this is more performant than just making the linearIndex contiguous. Fixes: #36956 Differential Revision: [D21144107](https://our.internmc.facebook.com/intern/diff/D21144107) [ghstack-poisoned]
gchanan
added a commit
that referenced
this pull request
Apr 20, 2020
#36962) * [v.1.5.0] Ensure linearIndex of advanced indexing backwards is contiguous. This is a more straightforward solution to the problem than #36957; I don't know about the relative performance. Fixes: #36956 ghstack-source-id: 43c48eaee7232cd3ed2b108edbbee24c11e8321a Pull Request resolved: #36959 * Fix test.
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 21, 2020
) Summary: Pull Request resolved: #36959 This is a more straightforward solution to the problem than #36957; I don't know about the relative performance. Fixes: #36956 Test Plan: Imported from OSS Differential Revision: D21144146 Pulled By: gchanan fbshipit-source-id: a10ab905219a73157d5d7183492b52d7c8dd6072
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This is attempt to make the current master behavior the same as on 1.4. I don't know if this is more performant than just making the linearIndex contiguous.
Fixes: #36956
Differential Revision: D21144107