[v1.5.0] Ensure remainder of advanced indexing backwards is contiguous. #36961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is attempt to make the current master behavior the same as on 1.4. I don't know if this is more performant than just making the linearIndex contiguous. Fixes: pytorch#36956 ghstack-source-id: f5ac46a6e77dce2e82396079d2ec426953ac5966 Pull Request resolved: pytorch#36957
💊 Build failures summary and remediationsAs of commit e591d75 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 2 times. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is attempt to make the current master behavior the same as on 1.4. I don't know if this is more performant than just making the linearIndex contiguous.
Fixes: #36956
ghstack-source-id: f5ac46a6e77dce2e82396079d2ec426953ac5966
Pull Request resolved: #36957