Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CUDA builds after the NativeFunction change #3757

Closed
wants to merge 5 commits into from
Closed

Fix CUDA builds after the NativeFunction change #3757

wants to merge 5 commits into from

Conversation

peterjc123
Copy link
Collaborator

No description provided.

@pytorchbot
Copy link
Collaborator

@peterjc123, thanks for your PR! We identified @zdevito to be a potential reviewer.

peterjc123
peterjc123 commented Nov 17, 2017
View reviewed changes
aten/src/ATen/CMakeLists.txt Outdated
@@ -144,7 +144,7 @@ FILE(GLOB_RECURSE all_templates "templates/*")

FILE(MAKE_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/ATen)

ADD_CUSTOM_COMMAND(OUTPUT ${generated_cpp}
ADD_CUSTOM_COMMAND(OUTPUT ${generated_cpp} #need changes here

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@peterjc123 peterjc123 changed the title [WIP]Fix CUDA buils after the NativeFunction change [WIP]Fix CUDA builds after the NativeFunction change Nov 17, 2017
@peterjc123 peterjc123 changed the title [WIP]Fix CUDA builds after the NativeFunction change Fix CUDA builds after the NativeFunction change Nov 19, 2017
@peterjc123
Copy link
Collaborator Author

May be we have to generate the template files first. It's not the best fix, but the only fix that i can figure out.

@peterjc123 peterjc123 mentioned this pull request Nov 22, 2017
Closed
@peterjc123
Copy link
Collaborator Author

#3992 is a better fix, closing this.

@peterjc123 peterjc123 closed this Dec 4, 2017
@peterjc123 peterjc123 deleted the cuda_fix branch December 24, 2017 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zdevito zdevito zdevito left review comments

@soumith soumith soumith left review comments

Assignees
No one assigned
Labels
open source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@peterjc123 @pytorchbot @zdevito @soumith @ezyang