Enabled per channel quantized static linear/conv #37622
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Enable channelwise quantized test on qlinear and qconv. Dynmaic linear to follow. Test Plan: pytest test/quantization/test_quantized.py pytest test/quantization/test_quantized_module.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Apr 30, 2020
💊 CI failures summary and remediationsAs of commit 8725f83 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 126 times. |
Summary: Enable channelwise quantized test on qlinear and qconv. Dynmaic linear to follow. Test Plan: pytest test/quantization/test_quantized.py pytest test/quantization/test_quantized_module.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21339046](https://our.internmc.facebook.com/intern/diff/D21339046) [ghstack-poisoned]
Summary: Enable channelwise quantized test on qlinear and qconv. Dynmaic linear to follow. Test Plan: pytest test/quantization/test_quantized.py pytest test/quantization/test_quantized_module.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21339046](https://our.internmc.facebook.com/intern/diff/D21339046) [ghstack-poisoned]
Summary: Enable channelwise quantized test on qlinear and qconv. Dynmaic linear to follow. Test Plan: pytest test/quantization/test_quantized.py pytest test/quantization/test_quantized_module.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21339046](https://our.internmc.facebook.com/intern/diff/D21339046) [ghstack-poisoned]
Summary: Enable channelwise quantized test on qlinear and qconv. Dynmaic linear to follow. Test Plan: pytest test/quantization/test_quantized.py pytest test/quantization/test_quantized_module.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21339046](https://our.internmc.facebook.com/intern/diff/D21339046) [ghstack-poisoned]
Summary: Enable channelwise quantized test on qlinear and qconv. Dynmaic linear to follow. Test Plan: pytest test/quantization/test_quantized.py pytest test/quantization/test_quantized_module.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21339046](https://our.internmc.facebook.com/intern/diff/D21339046) [ghstack-poisoned]
Summary: Enable channelwise quantized test on qlinear and qconv. Dynmaic linear to follow. Test Plan: pytest test/quantization/test_quantized.py pytest test/quantization/test_quantized_module.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21339046](https://our.internmc.facebook.com/intern/diff/D21339046) [ghstack-poisoned]
Closed
Summary: Enable channelwise quantized test on qlinear and qconv. Dynmaic linear to follow. Test Plan: pytest test/quantization/test_quantized.py pytest test/quantization/test_quantized_module.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21339046](https://our.internmc.facebook.com/intern/diff/D21339046) [ghstack-poisoned]
Summary: Enable channelwise quantized test on qlinear and qconv. Dynmaic linear to follow. Test Plan: pytest test/quantization/test_quantized.py pytest test/quantization/test_quantized_module.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21339046](https://our.internmc.facebook.com/intern/diff/D21339046) [ghstack-poisoned]
Summary: Enable channelwise quantized test on qlinear and qconv. Dynmaic linear to follow. Test Plan: pytest test/quantization/test_quantized.py pytest test/quantization/test_quantized_module.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21339046](https://our.internmc.facebook.com/intern/diff/D21339046) [ghstack-poisoned]
Summary: Enable channelwise quantized test on qlinear and qconv. Dynmaic linear to follow. Test Plan: pytest test/quantization/test_quantized.py pytest test/quantization/test_quantized_module.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21339046](https://our.internmc.facebook.com/intern/diff/D21339046) [ghstack-poisoned]
Summary: Enable channelwise quantized test on qlinear and qconv. Dynmaic linear to follow. Test Plan: pytest test/quantization/test_quantized.py pytest test/quantization/test_quantized_module.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21339046](https://our.internmc.facebook.com/intern/diff/D21339046) [ghstack-poisoned]
Summary: Enable channelwise quantized tests on qlinear and qconv. Dynmaic linear to follow. Test Plan: pytest test/quantization/test_quantized.py pytest test/quantization/test_quantized_module.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21339046](https://our.internmc.facebook.com/intern/diff/D21339046) [ghstack-poisoned]
xuezhou1998
pushed a commit
to xuezhou1998/new_pytorch
that referenced
this pull request
May 9, 2020
Summary: Enable channelwise quantized test on qlinear and qconv. Dynmaic linear to follow. Test Plan: pytest test/quantization/test_quantized.py pytest test/quantization/test_quantized_module.py Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 3ad2892fb90e634d48f56d860a942e98b0c70639 Pull Request resolved: pytorch/pytorch#37622
Summary: Enable channelwise quantized tests on qlinear and qconv. Dynmaic linear to follow. Test Plan: pytest test/quantization/test_quantized.py pytest test/quantization/test_quantized_module.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21339046](https://our.internmc.facebook.com/intern/diff/D21339046) [ghstack-poisoned]
Summary: Enable channelwise quantized tests on qlinear and qconv. Dynmaic linear to follow. Test Plan: pytest test/quantization/test_quantized.py pytest test/quantization/test_quantized_module.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21339046](https://our.internmc.facebook.com/intern/diff/D21339046) [ghstack-poisoned]
Summary: Enable channelwise quantized tests on qlinear and qconv. Dynmaic linear to follow. Test Plan: pytest test/quantization/test_quantized.py pytest test/quantization/test_quantized_module.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21339046](https://our.internmc.facebook.com/intern/diff/D21339046) [ghstack-poisoned]
Summary: Enable channelwise quantized tests on qlinear and qconv. Dynmaic linear to follow. Test Plan: pytest test/quantization/test_quantized.py pytest test/quantization/test_quantized_module.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21339046](https://our.internmc.facebook.com/intern/diff/D21339046) [ghstack-poisoned]
dreiss
reviewed
May 14, 2020
Comment on lines
+283
to
+287
| // Need to move the check here since we are releasing the weights. | ||
| TORCH_CHECK( | ||
| orig_weight.qscheme() == at::kPerTensorAffine, | ||
| "quantized::linear_dynamic (qnnpack) only supports " | ||
| "Per Tensor Quantization Scheme"); |
There was a problem hiding this comment.
I don't get this. Can the scheme change between when you call prepack and here? Also, I think I understand "move" in the context of this diff, but I don't think someone looking at the new version of the code in the future will understand what's moving here.
There was a problem hiding this comment.
This will be removed by a later PR in the stack. I just split the PRs for ease of review and ease of dissecting any future failures. I do understand though it is a cryptic comment.
Regarding qscheme changing. I don't think this is possible. Do you have a reason to believe that it can?
Summary: Enable channelwise quantized tests on qlinear and qconv. Dynmaic linear to follow. Test Plan: pytest test/quantization/test_quantized.py pytest test/quantization/test_quantized_module.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21339046](https://our.internmc.facebook.com/intern/diff/D21339046) [ghstack-poisoned]
Summary: Enable channelwise quantized tests on qlinear and qconv. Dynmaic linear to follow. Test Plan: pytest test/quantization/test_quantized.py pytest test/quantization/test_quantized_module.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21339046](https://our.internmc.facebook.com/intern/diff/D21339046) [ghstack-poisoned]
Summary: Enable channelwise quantized tests on qlinear and qconv. Dynmaic linear to follow. Test Plan: pytest test/quantization/test_quantized.py pytest test/quantization/test_quantized_module.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21339046](https://our.internmc.facebook.com/intern/diff/D21339046) [ghstack-poisoned]
Summary: Enable channelwise quantized tests on qlinear and qconv. Dynmaic linear to follow. Test Plan: pytest test/quantization/test_quantized.py pytest test/quantization/test_quantized_module.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21339046](https://our.internmc.facebook.com/intern/diff/D21339046) [ghstack-poisoned]
dreiss
approved these changes
May 18, 2020
Summary: Enable channelwise quantized tests on qlinear and qconv. Dynmaic linear to follow. Test Plan: pytest test/quantization/test_quantized.py pytest test/quantization/test_quantized_module.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21339046](https://our.internmc.facebook.com/intern/diff/D21339046) [ghstack-poisoned]
Summary: Enable channelwise quantized tests on qlinear and qconv. Dynmaic linear to follow. Test Plan: pytest test/quantization/test_quantized.py pytest test/quantization/test_quantized_module.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21339046](https://our.internmc.facebook.com/intern/diff/D21339046) [ghstack-poisoned]
Summary: Enable channelwise quantized tests on qlinear and qconv. Dynmaic linear to follow. Test Plan: pytest test/quantization/test_quantized.py pytest test/quantization/test_quantized_module.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21339046](https://our.internmc.facebook.com/intern/diff/D21339046) [ghstack-poisoned]
Summary: Enable channelwise quantized tests on qlinear and qconv. Dynmaic linear to follow. Test Plan: pytest test/quantization/test_quantized.py pytest test/quantization/test_quantized_module.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21339046](https://our.internmc.facebook.com/intern/diff/D21339046) [ghstack-poisoned]
|
This pull request has been merged in b8eae1e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Enable channelwise quantized tests on qlinear and qconv. Dynmaic linear to follow.
Test Plan:
pytest test/quantization/test_quantized.py
pytest test/quantization/test_quantized_module.py
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D21339046