New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some TODO fixes. #37829

Closed

kimishpatel wants to merge 19 commits into gh/kimishpatel/21/base from gh/kimishpatel/21/head

Contributor

kimishpatel commented May 5, 2020 •

edited

Stack from ghstack:

Some TODO fixes. #37829 Some TODO fixes.
Perf optimization for conv and gemm kernels. #37626 Perf optimization for conv and gemm kernels.
Added per channel separate test cases for fc and deconv tests. #37624 Added per channel separate test cases for fc and deconv tests.
Changes to enable per channel support on dynamic linear. #37623 Changes to enable per channel support on dynamic linear.
Enabled per channel quantized static linear/conv #37622 Enabled per channel quantized static linear/conv
Added per channel kernels for depthwise conv. #37621 Added per channel kernels for depthwise conv.
Changes to enable per channel requant. #37620 Changes to enable per channel requant.
Enable per channel zero point. #37619 Enable per channel zero point.
Interface changes to enable per channel quant. #37618 Interface changes to enable per channel quant.

Summary:

Removes memset not needed.
Removed separate packing function added for dynamic linear.

Test Plan:
Quantized tests.

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D21404841


          Some TODO fixes.

5ac656c

Summary:
- Removes memset not needed.
- Removed separate packing function added for dynamic linear.

Test Plan:
Quantized tests.

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]

This was referenced May 5, 2020

Interface changes to enable per channel quant. #37618

Closed

Enable per channel zero point. #37619

Closed

Changes to enable per channel requant. #37620

Closed

Added per channel kernels for depthwise conv. #37621

Closed

Enabled per channel quantized static linear/conv #37622

Closed

Changes to enable per channel support on dynamic linear. #37623

Closed

Added per channel separate test cases for fc and deconv tests. #37624

Closed

Enable channelwise quantized test for dynamic linear. #37625

Merged

Perf optimization for conv and gemm kernels. #37626

Closed

dr-ci bot commented May 5, 2020 •

edited

💊 CI failures summary and remediations

As of commit 9f8f074 (more details on the Dr. CI page):

1/1 failures possibly* introduced in this PR
- 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed

Failed: pr/py3.6-clang7-rocmdeb-ubuntu16.04

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 89 times.


          Update on "Some TODO fixes."

b88b778

Summary:
- Removes memset not needed.
- Removed separate packing function added for dynamic linear.

Test Plan:
Quantized tests.

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D21404841](https://our.internmc.facebook.com/intern/diff/D21404841)

[ghstack-poisoned]

kimishpatel added a commit that referenced this pull request


          Some TODO fixes.

5bac21a

Summary:
- Removes memset not needed.
- Removed separate packing function added for dynamic linear.

Test Plan:
Quantized tests.

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: fbdd7393ea8c412c68a9513f62c2386244f5e82f
Pull Request resolved: #37829


          Update on "Some TODO fixes."

7f66548

Summary:
- Removes memset not needed.
- Removed separate packing function added for dynamic linear.

Test Plan:
Quantized tests.

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D21404841](https://our.internmc.facebook.com/intern/diff/D21404841)

[ghstack-poisoned]

kimishpatel added a commit that referenced this pull request


          Some TODO fixes.

a908a76

Summary:
- Removes memset not needed.
- Removed separate packing function added for dynamic linear.

Test Plan:
Quantized tests.

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: a360c1300eb34e3a9ab0a3aca996c7834bd6f0fd
Pull Request resolved: #37829


          Update on "Some TODO fixes."

126ffe2

Summary:
- Removes memset not needed.
- Removed separate packing function added for dynamic linear.

Test Plan:
Quantized tests.

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D21404841](https://our.internmc.facebook.com/intern/diff/D21404841)

[ghstack-poisoned]

kimishpatel added a commit that referenced this pull request


          Some TODO fixes.

bd95288

Summary:
- Removes memset not needed.
- Removed separate packing function added for dynamic linear.

Test Plan:
Quantized tests.

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 2957e1cdd470d5c6cc908924c37a8b41b7c121a4
Pull Request resolved: #37829


          Update on "Some TODO fixes."

35b11e1

Summary:
- Removes memset not needed.
- Removed separate packing function added for dynamic linear.

Test Plan:
Quantized tests.

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D21404841](https://our.internmc.facebook.com/intern/diff/D21404841)

[ghstack-poisoned]


          Update on "Some TODO fixes."

5bcafe4

Summary:
- Removes memset not needed.
- Removed separate packing function added for dynamic linear.

Test Plan:
Quantized tests.

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D21404841](https://our.internmc.facebook.com/intern/diff/D21404841)

[ghstack-poisoned]

kimishpatel added a commit that referenced this pull request


          Some TODO fixes.

12d79e1

Summary:
- Removes memset not needed.
- Removed separate packing function added for dynamic linear.

Test Plan:
Quantized tests.

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 1537d72717c3adb8e5fa82fc6f3b8e469353326c
Pull Request resolved: #37829


          Update on "Some TODO fixes."

8b66548

Summary:
- Removes memset not needed.
- Removed separate packing function added for dynamic linear.

Test Plan:
Quantized tests.

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D21404841](https://our.internmc.facebook.com/intern/diff/D21404841)

[ghstack-poisoned]

kimishpatel added a commit that referenced this pull request


          Some TODO fixes.

Summary:
- Removes memset not needed.
- Removed separate packing function added for dynamic linear.

Test Plan:
Quantized tests.

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 941031fe3da4bd99bb8e42c7a045aee758ae6862
Pull Request resolved: #37829


          Update on "Some TODO fixes."

c323167

Summary:
- Removes memset not needed.
- Removed separate packing function added for dynamic linear.

Test Plan:
Quantized tests.

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D21404841](https://our.internmc.facebook.com/intern/diff/D21404841)

[ghstack-poisoned]

kimishpatel added a commit that referenced this pull request


          Some TODO fixes.

66d3312

Summary:
- Removes memset not needed.
- Removed separate packing function added for dynamic linear.

Test Plan:
Quantized tests.

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: fabd6d0265e3f0a72e07b4d275f35ace3d0e7972
Pull Request resolved: #37829


          Update on "Some TODO fixes."

2bcf396

Summary:
- Removes memset not needed.
- Removed separate packing function added for dynamic linear.

Test Plan:
Quantized tests.

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D21404841](https://our.internmc.facebook.com/intern/diff/D21404841)

[ghstack-poisoned]

kimishpatel added a commit that referenced this pull request


          Some TODO fixes.

49665c1

Summary:
- Removes memset not needed.
- Removed separate packing function added for dynamic linear.

Test Plan:
Quantized tests.

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 3ff62b7909d69f571e679024014f908e44611f47
Pull Request resolved: #37829

kimishpatel mentioned this pull request

Change input scale to double type for conv params. #38346

Closed


          Update on "Some TODO fixes."

fac3351

Summary:
- Removes memset not needed.
- Removed separate packing function added for dynamic linear.

Test Plan:
Quantized tests.

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D21404841](https://our.internmc.facebook.com/intern/diff/D21404841)

[ghstack-poisoned]

kimishpatel added a commit that referenced this pull request


          Some TODO fixes.

648a5ea

Summary:
- Removes memset not needed.
- Removed separate packing function added for dynamic linear.

Test Plan:
Quantized tests.

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 378bc4b1632f523caf5cc7afb6014a5bda6e00a9
Pull Request resolved: #37829


          Update on "Some TODO fixes."

a93c1d8

Summary:
- Removes memset not needed.
- Removed separate packing function added for dynamic linear.

Test Plan:
Quantized tests.

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D21404841](https://our.internmc.facebook.com/intern/diff/D21404841)

[ghstack-poisoned]

kimishpatel added a commit that referenced this pull request


          Some TODO fixes.

8f1da1d

Summary:
- Removes memset not needed.
- Removed separate packing function added for dynamic linear.

Test Plan:
Quantized tests.

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 378bc4b1632f523caf5cc7afb6014a5bda6e00a9
Pull Request resolved: #37829


          Update on "Some TODO fixes."

b341c21

Summary:
- Removes memset not needed.
- Removed separate packing function added for dynamic linear.

Test Plan:
Quantized tests.

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D21404841](https://our.internmc.facebook.com/intern/diff/D21404841)

[ghstack-poisoned]

kimishpatel added a commit that referenced this pull request


          Some TODO fixes.

f58bbdf

Summary:
- Removes memset not needed.
- Removed separate packing function added for dynamic linear.

Test Plan:
Quantized tests.

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 0312717be4f08d23f56e6ad7ff2127e9fa65fe7c
Pull Request resolved: #37829


          Update on "Some TODO fixes."

a5c3b63

Summary:
- Removes memset not needed.
- Removed separate packing function added for dynamic linear.

Test Plan:
Quantized tests.

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D21404841](https://our.internmc.facebook.com/intern/diff/D21404841)

[ghstack-poisoned]

kimishpatel added a commit that referenced this pull request


          Some TODO fixes.

b345cde

Summary:
- Removes memset not needed.
- Removed separate packing function added for dynamic linear.

Test Plan:
Quantized tests.

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: f27c37fd5b4e8428c85dae6a4a2437db3bbfd5a9
Pull Request resolved: #37829


          Update on "Some TODO fixes."

22ad93d

Summary:
- Removes memset not needed.
- Removed separate packing function added for dynamic linear.

Test Plan:
Quantized tests.

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D21404841](https://our.internmc.facebook.com/intern/diff/D21404841)

[ghstack-poisoned]

kimishpatel added a commit that referenced this pull request


          Some TODO fixes.

9e42448

Summary:
- Removes memset not needed.
- Removed separate packing function added for dynamic linear.

Test Plan:
Quantized tests.

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: e0d401c832c229682be2ac81a1e3ac71dfbd17a5
Pull Request resolved: #37829


          Update on "Some TODO fixes."

88e875b

Summary:
- Removes memset not needed.
- Removed separate packing function added for dynamic linear.

Test Plan:
Quantized tests.

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D21404841](https://our.internmc.facebook.com/intern/diff/D21404841)

[ghstack-poisoned]

kimishpatel added a commit that referenced this pull request


          Some TODO fixes.

3d72659

Summary:
- Removes memset not needed.
- Removed separate packing function added for dynamic linear.

Test Plan:
Quantized tests.

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 671c123583e1195ababdae38f5b62b4e4dab76fa
Pull Request resolved: #37829

dreiss approved these changes

View reviewed changes


          Update on "Some TODO fixes."

Summary:
- Removes memset not needed.
- Removed separate packing function added for dynamic linear.

Test Plan:
Quantized tests.

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D21404841](https://our.internmc.facebook.com/intern/diff/D21404841)

[ghstack-poisoned]

kimishpatel added a commit that referenced this pull request


          Some TODO fixes.

dec1e57

Summary:
- Removes memset not needed.
- Removed separate packing function added for dynamic linear.

Test Plan:
Quantized tests.

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: dd427cf6ce53e64ab246994c2a14f5914e909f05
Pull Request resolved: #37829


          Update on "Some TODO fixes."

b9f4e88

Summary:
- Removes memset not needed.
- Removed separate packing function added for dynamic linear.

Test Plan:
Quantized tests.

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D21404841](https://our.internmc.facebook.com/intern/diff/D21404841)

[ghstack-poisoned]

kimishpatel added a commit that referenced this pull request


          Some TODO fixes.

59271cd

Summary:
- Removes memset not needed.
- Removed separate packing function added for dynamic linear.

Test Plan:
Quantized tests.

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: dcd5d3dd0017e3af1d85b7c911f9a1ba72251d3b
Pull Request resolved: #37829


          Update on "Some TODO fixes."

edc3575

Summary:
- Removes memset not needed.
- Removed separate packing function added for dynamic linear.

Test Plan:
Quantized tests.

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D21404841](https://our.internmc.facebook.com/intern/diff/D21404841)

[ghstack-poisoned]

kimishpatel added a commit that referenced this pull request


          Some TODO fixes.

7fe7d31

Summary:
- Removes memset not needed.
- Removed separate packing function added for dynamic linear.

Test Plan:
Quantized tests.

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: ddca228090cc8b75a2d96a3d88af5b5a7b693846
Pull Request resolved: #37829


          Update on "Some TODO fixes."

9f8f074

Summary:
- Removes memset not needed.
- Removed separate packing function added for dynamic linear.

Test Plan:
Quantized tests.

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D21404841](https://our.internmc.facebook.com/intern/diff/D21404841)

[ghstack-poisoned]

kimishpatel added a commit that referenced this pull request


          Some TODO fixes.

2d37c92

Summary:
- Removes memset not needed.
- Removed separate packing function added for dynamic linear.

Test Plan:
Quantized tests.

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 8a9ba56ac9e627f0ea0ddaa3c0c0543842898271
Pull Request resolved: #37829

facebook-github-bot closed this in

a83f253

facebook-github-bot added the merged label

Contributor

facebook-github-bot commented May 21, 2020

This pull request has been merged in a83f253.

1 similar comment

Contributor

facebook-github-bot commented May 21, 2020

This pull request has been merged in a83f253.

facebook-github-bot deleted the gh/kimishpatel/21/head branch

May 25, 2020 14:16

mruberry added the Merged label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment