Fix complex tensor printing #38031
Closed
Fix complex tensor printing #38031
+16
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
[ghstack-poisoned]
anjali411
added a commit
that referenced
this pull request
May 7, 2020
ghstack-source-id: 652f9f010150fd1a188392751282e2b8f699d1b9 Pull Request resolved: #38031
ssnl
reviewed
May 7, 2020
torch/_tensor_str.py
Outdated
| @@ -280,7 +280,9 @@ def _str(self): | |||
| or (self.device.type == 'cuda' and torch.cuda.current_device() != self.device.index): | |||
| suffixes.append('device=\'' + str(self.device) + '\'') | |||
|
|
|||
| has_default_dtype = self.dtype in (torch.get_default_dtype(), torch.int64, torch.bool) | |||
| # TODO: add an API to map real -> complex dtypes | |||
| _default_complex_dtype = torch.cfloat if torch.get_default_dtype() == torch.float else torch.cdouble | |||
There was a problem hiding this comment.
so if default dtype is half this is cdouble?
There was a problem hiding this comment.
good point! no it should be cdouble if double else cfloat, similar to the logic here
There was a problem hiding this comment.
will update! updated
💊 CI failures summary and remediationsAs of commit 8b2acc1 (more details on the Dr. CI page):
Extra GitHub checks: 1 failed
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 6 times. |
[ghstack-poisoned]
anjali411
added a commit
that referenced
this pull request
May 11, 2020
ghstack-source-id: 34bfb5c5632302258f29eb29a199dc49302ca8d6 Pull Request resolved: #38031
Differential Revision: [D21502915](https://our.internmc.facebook.com/intern/diff/D21502915) [ghstack-poisoned]
anjali411
added a commit
that referenced
this pull request
May 12, 2020
ghstack-source-id: 96c5973dedb918eea36a825c1d04737c9268b059 Pull Request resolved: #38031
|
@anjali411 merged this pull request in 375ddb0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D21502915