Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dll load failure in virtual environments on Windows #39622

Closed
wants to merge 5 commits into from
Closed

Fix dll load failure in virtual environments on Windows #39622

wants to merge 5 commits into from

Conversation

peterjc123
Copy link
Collaborator

Fixes #39620.

@peterjc123 peterjc123 requested review from ezyang and malfet June 6, 2020 08:25
@peterjc123
Copy link
Collaborator Author

@ashwithadevasya Could you please test whether this fix is sufficient to solve your problem?

@dr-ci
Copy link

dr-ci bot commented Jun 6, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 3ef5e73 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 13 times.

@peterjc123 peterjc123 mentioned this pull request Jun 6, 2020
Closed
@ezyang
Copy link
Contributor

ezyang commented Jun 8, 2020

@peterjc123 do you think it would be possible to add a comment at the top of this function explaining what it is doing, how it is going about doing it, and how some alternate plausible implementation strategies (e.g., the ones from before this bug) don't work?

malfet
malfet reviewed Jun 9, 2020
View reviewed changes
torch/__init__.py Outdated Show resolved Hide resolved
torch/__init__.py Outdated Show resolved Hide resolved
@peterjc123
Copy link
Collaborator Author

@malfet @ezyang Done.

facebook-github-bot
facebook-github-bot reviewed Jun 9, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malfet is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@malfet merged this pull request in 3413f0a.

@peterjc123 peterjc123 deleted the virtualenv_dll_load_fix branch July 1, 2020 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@malfet malfet malfet approved these changes

@ezyang ezyang Awaiting requested review from ezyang

Assignees
No one assigned
Labels
Merged open source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DLL load failure when trying to import torch in a virtual python environment created by venv
6 participants
@peterjc123 @ezyang @facebook-github-bot @malfet @pytorchbot @mruberry