Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add at::tensor(complex) and torch::tensor(complex) overload #39793

Closed
wants to merge 10 commits into from

Conversation

zasdfgbnm
Copy link
Collaborator

No description provided.

@zasdfgbnm zasdfgbnm requested a review from anjali411 June 10, 2020 18:24
@dr-ci
Copy link

dr-ci bot commented Jun 10, 2020

💊 CI failures summary and remediations

As of commit 6cd83c3 (more details on the Dr. CI page):


  • 2/2 failures possibly* introduced in this PR
    • 1/2 non-CircleCI failure(s)

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_macos_10_13_py3_test (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

Jun 11 12:24:46 RuntimeError: test_cuda failed!
Jun 11 12:24:46   File "/Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/librosa/util/utils.py", line 15, in <module> 
Jun 11 12:24:46     from .decorators import deprecated 
Jun 11 12:24:46   File "/Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/librosa/util/decorators.py", line 9, in <module> 
Jun 11 12:24:46     from numba.decorators import jit as optional_jit 
Jun 11 12:24:46 ModuleNotFoundError: No module named 'numba.decorators' 
Jun 11 12:24:46 Traceback (most recent call last): 
Jun 11 12:24:46   File "test/run_test.py", line 711, in <module> 
Jun 11 12:24:46     main() 
Jun 11 12:24:46   File "test/run_test.py", line 704, in main 
Jun 11 12:24:46     raise RuntimeError(message) 
Jun 11 12:24:46 RuntimeError: test_cuda failed! 
Jun 11 12:24:46 + cleanup 
Jun 11 12:24:46 + retcode=1 
Jun 11 12:24:46 + set +x 

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 31 times.

@zasdfgbnm zasdfgbnm changed the title Add at::tensor(complex) overload [WIP] Add at::tensor(complex) overload Jun 10, 2020
@zasdfgbnm zasdfgbnm changed the title [WIP] Add at::tensor(complex) overload Add at::tensor(complex) and torch::tensor(complex) overload Jun 10, 2020
@zasdfgbnm
Copy link
Collaborator Author

@anjali411 The test is passing on my local box, hopefully this is working.
Also cc: @yf225 for C++ API change

@yf225 yf225 requested a review from glaringlee June 10, 2020 23:33
@yf225
Copy link
Contributor

yf225 commented Jun 10, 2020

cc. @glaringlee for C++ API change :D

@anjali411 anjali411 added the module: complex Related to complex number support in PyTorch label Jun 10, 2020
@zasdfgbnm
Copy link
Collaborator Author

This should be ready

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@anjali411 merged this pull request in 954a59a.

xwang233 pushed a commit to xwang233/pytorch that referenced this pull request Jun 20, 2020
…39793)

Summary: Pull Request resolved: pytorch#39793

Differential Revision: D22067181

Pulled By: anjali411

fbshipit-source-id: 3cec1289a8aa3a9cc6bd1fcdb2974f858f75f7bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merged module: complex Related to complex number support in PyTorch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants