Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ONNX: fix bug in export of cumsum operator #40044

Closed
wants to merge 1 commit into from

Conversation

@yaeldekel
Copy link
Contributor

yaeldekel commented Jun 15, 2020

The "cast" operator is currently added after the cumsum operator, but it should be added before, since torch.cumsum supports more types than ONNX (specifically, bool).

@dr-ci
Copy link

dr-ci bot commented Jun 15, 2020

💊 CI failures summary and remediations

As of commit e068509 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 5 times.

@yaeldekel yaeldekel force-pushed the yaeldekel:cumsum branch from ce451d3 to e068509 Jun 16, 2020
Copy link
Collaborator

neginraoof left a comment

Looks good! Thanks!

@KsenijaS
Copy link
Collaborator

KsenijaS commented Jun 18, 2020

looks good. LGTM!

Copy link
Member

houseroad left a comment

Thanks for fixing.

Copy link
Contributor

facebook-github-bot left a comment

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 22, 2020

@houseroad merged this pull request in 3fa0b1e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.