-
Notifications
You must be signed in to change notification settings - Fork 22.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add examples and tests for combining static/class method with async execution #40619
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xecution [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit c3b7c6c (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 13 times. |
…ith async execution" [ghstack-poisoned]
…ith async execution" [ghstack-poisoned]
rohan-varma
reviewed
Jun 26, 2020
…ith async execution" Differential Revision: [D22258407](https://our.internmc.facebook.com/intern/diff/D22258407) [ghstack-poisoned]
mrshenli
added a commit
that referenced
this pull request
Jun 26, 2020
…xecution ghstack-source-id: 658df8f6f30ce0d9cf4a38f766d9344fdd89b658 Pull Request resolved: #40619
rohan-varma
approved these changes
Jun 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for clarifying the earlier comment I had! LGTM
mrshenli
added a commit
to mrshenli/pytorch
that referenced
this pull request
Jun 29, 2020
…xecution (pytorch#40619) Summary: Pull Request resolved: pytorch#40619 Test Plan: Imported from OSS Differential Revision: D22258407 Pulled By: mrshenli fbshipit-source-id: 036d85a2affc4505efd2df197fc513dba010e359
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D22258407