Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples and tests for combining static/class method with async execution #40619

Closed
wants to merge 4 commits into from

Conversation

mrshenli
Copy link
Contributor

@mrshenli mrshenli commented Jun 26, 2020

Stack from ghstack:

Differential Revision: D22258407

@dr-ci
Copy link

dr-ci bot commented Jun 26, 2020

💊 CI failures summary and remediations

As of commit c3b7c6c (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 13 times.

mrshenli added a commit that referenced this pull request Jun 26, 2020
…xecution

ghstack-source-id: 658df8f6f30ce0d9cf4a38f766d9344fdd89b658
Pull Request resolved: #40619
Copy link
Member

@rohan-varma rohan-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying the earlier comment I had! LGTM

@facebook-github-bot
Copy link
Contributor

@mrshenli merged this pull request in 5217227.

mrshenli added a commit to mrshenli/pytorch that referenced this pull request Jun 29, 2020
…xecution (pytorch#40619)

Summary: Pull Request resolved: pytorch#40619

Test Plan: Imported from OSS

Differential Revision: D22258407

Pulled By: mrshenli

fbshipit-source-id: 036d85a2affc4505efd2df197fc513dba010e359
malfet pushed a commit that referenced this pull request Jun 30, 2020
…xecution (#40619) (#40688)

Summary: Pull Request resolved: #40619

Test Plan: Imported from OSS

Differential Revision: D22258407

Pulled By: mrshenli

fbshipit-source-id: 036d85a2affc4505efd2df197fc513dba010e359
@facebook-github-bot facebook-github-bot deleted the gh/mrshenli/207/head branch July 1, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants