Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

torch.nn.Unfold accepts 0-dim for batch size #40689

Closed
wants to merge 4 commits into from

Conversation

v0dro
Copy link
Contributor

@v0dro v0dro commented Jun 29, 2020

In partial completion of #12013

Allows specifying a tensor with 0-dim batch size for torch.nn.Unfold().

@dr-ci
Copy link

dr-ci bot commented Jun 29, 2020

💊 CI failures summary and remediations

As of commit 81680d8 (more details on the Dr. CI page):



🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_clang5_asan_build (1/1)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

Oct 09 09:08:02 caused by: Connection refused (os error 111)
Oct 09 09:08:02 ++++ extract_trap_cmd 
Oct 09 09:08:02 ++++ printf '%s\n' '' 
Oct 09 09:08:02 +++ printf '%s\n' cleanup 
Oct 09 09:08:02 ++ trap -- ' 
Oct 09 09:08:02 cleanup' EXIT 
Oct 09 09:08:02 ++ [[ pytorch-linux-xenial-py3-clang5-asan-build != *pytorch-win-* ]] 
Oct 09 09:08:02 ++ which sccache 
Oct 09 09:08:02 ++ sccache --stop-server 
Oct 09 09:08:02 Stopping sccache server... 
Oct 09 09:08:02 error: couldn't connect to server 
Oct 09 09:08:02 caused by: Connection refused (os error 111) 
Oct 09 09:08:02 ++ true 
Oct 09 09:08:02 ++ rm /var/lib/jenkins/sccache_error.log 
Oct 09 09:08:02 rm: cannot remove '/var/lib/jenkins/sccache_error.log': No such file or directory 
Oct 09 09:08:02 ++ true 
Oct 09 09:08:02 ++ [[ pytorch-linux-xenial-py3-clang5-asan-build == *rocm* ]] 
Oct 09 09:08:02 ++ SCCACHE_ERROR_LOG=/var/lib/jenkins/sccache_error.log 
Oct 09 09:08:02 ++ SCCACHE_IDLE_TIMEOUT=1200 
Oct 09 09:08:02 ++ RUST_LOG=sccache::server=error 
Oct 09 09:08:02 ++ sccache --start-server 
Oct 09 09:08:02 Starting sccache server... 

❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build pytorch_macos_10_13_py3_build (1/1)

Step: "Update Homebrew" (full log | diagnosis details | 🔁 rerun) ❄️

fatal: Could not read from remote repository.
remote: Total 60 (delta 51), reused 21 (delta 17), pack-reused 0         
Unpacking objects:  96% (58/60) Unpacking objects:  98% (59/60) Unpacking objects: 100% (60/60) Unpacking objects: 100% (60/60), 13.00 KiB | 316.00 KiB/s, done. 
From ssh://github.com/Homebrew/homebrew-cask-versions 
 + f127a2be3...8d1d26f57 master     -> origin/master  (forced update) 
+ git reset --hard origin/master 
HEAD is now at 8d1d26f57 Update microsoft-edge-beta from 86.0.622.36 to 86.0.622.38 (#9741) 
+ for path in '$(find /usr/local/Homebrew -type d -name .git)' 
+ cd /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/.git/.. 
+ git fetch --depth=1 origin 
Connection to github.com closed by remote host.  
fatal: Could not read from remote repository. 
 
Please make sure you have the correct access rights 
and the repository exists. 

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 7 times.

@v0dro v0dro requested a review from xmnlab June 29, 2020 05:17
@colesbury colesbury added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 30, 2020
@v0dro
Copy link
Contributor Author

v0dro commented Oct 16, 2020

@ngimel request review.

@rgommers rgommers removed the request for review from xmnlab October 19, 2020 14:12
@v0dro
Copy link
Contributor Author

v0dro commented Oct 21, 2020

Any update on this?

Copy link
Collaborator

@ngimel ngimel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ngimel merged this pull request in 982fa07.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants