[JIT] Add support for backend-lowered submodules #41146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary** This commit adds support for using `Modules` that have been lowered as submodules in `ScriptModules`. **Test Plan** This commit adds execution and save/load tests to test_backends.py for backend-lowered submodules. **Fixes** This commit fixes #40069. [ghstack-poisoned]
SplitInfinity
pushed a commit
that referenced
this pull request
Jul 8, 2020
**Summary** This commit adds support for using `Modules` that have been lowered as submodules in `ScriptModules`. **Test Plan** This commit adds execution and save/load tests to test_backends.py for backend-lowered submodules. **Fixes** This commit fixes #40069. ghstack-source-id: b6aabcfedb34e1f68b26b0c8a546298d5c41152c Pull Request resolved: #41146
facebook-github-bot
added
the
oncall: jit
|
@suo This is the one that got reverted but somehow the tests are clean now without any extra changes? I don't know what's going on :( |
💊 CI failures summary and remediationsAs of commit 262ee36 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 12 times. |
malfet
reviewed
Jul 10, 2020
malfet
reviewed
Jul 10, 2020
**Summary** This commit adds support for using `Modules` that have been lowered as submodules in `ScriptModules`. **Test Plan** This commit adds execution and save/load tests to test_backends.py for backend-lowered submodules. **Fixes** This commit fixes #40069. Differential Revision: [D22459543](https://our.internmc.facebook.com/intern/diff/D22459543) [ghstack-poisoned]
**Summary** This commit adds support for using `Modules` that have been lowered as submodules in `ScriptModules`. **Test Plan** This commit adds execution and save/load tests to test_backends.py for backend-lowered submodules. **Fixes** This commit fixes #40069. Differential Revision: [D22459543](https://our.internmc.facebook.com/intern/diff/D22459543) [ghstack-poisoned]
SplitInfinity
pushed a commit
that referenced
this pull request
Jul 10, 2020
**Summary** This commit adds support for using `Modules` that have been lowered as submodules in `ScriptModules`. **Test Plan** This commit adds execution and save/load tests to test_backends.py for backend-lowered submodules. **Fixes** This commit fixes #40069. ghstack-source-id: 8b8ad87d29b0ca31e9d8e79b2012fe51eb0f78e7 Pull Request resolved: #41146
ailzhang
approved these changes
Jul 10, 2020
|
@SplitInfinity merged this pull request in ce3ba3b. |
This was referenced Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary
This commit adds support for using
Modulesthat have been lowered assubmodules in
ScriptModules.Test Plan
This commit adds execution and save/load tests to test_backends.py for
backend-lowered submodules.
Fixes
This commit fixes #40069.
Differential Revision: D22459543