[quant] Make PerChannel Observer work with float qparams #42690
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Add implementation for new qscheme per_channel_affine_float_qparams in observer Test Plan: python test/test_quantization.py TestObserver.test_per_channel_observers Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
supriyar
added a commit
that referenced
this pull request
Aug 6, 2020
Summary: Add implementation for new qscheme per_channel_affine_float_qparams in observer Test Plan: python test/test_quantization.py TestObserver.test_per_channel_observers Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: adf42b3867df1acdc35b696374132d00f6ccdb99 Pull Request resolved: #42690
💊 CI failures summary and remediationsAs of commit 3086331 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 45 times. |
vkuzo
reviewed
Aug 7, 2020
vkuzo
reviewed
Aug 7, 2020
vkuzo
reviewed
Aug 7, 2020
torch/quantization/observer.py
Outdated
Comment on lines
220
to
221
| min_val = torch.min(min_val, torch.zeros_like(min_val)) | ||
| max_val = torch.max(max_val, torch.zeros_like(max_val)) |
There was a problem hiding this comment.
this code was a bit confusing (before this PR). Maybe we can rename these something like min_val_neg and max_val_pos in the rest of the function?
vkuzo
reviewed
Aug 7, 2020
torch/quantization/observer.py
Outdated
| @@ -232,6 +234,11 @@ def _calculate_qparams(self, min_val, max_val): | |||
| zero_point = zero_point.new_full(zero_point.size(), (qmin + qmax) // 2) | |||
| else: | |||
| zero_point = zero_point.new_full(zero_point.size(), 128) | |||
| elif self.qscheme == torch.per_channel_affine_float_qparams: | |||
| scale = (orig_max - orig_min) / float(qmax - qmin) | |||
There was a problem hiding this comment.
ideally this should be max_val - min_val, since that's what is actually happening. The other qschemes are not using observed min and max directly.
There was a problem hiding this comment.
Right. Maybe I can rename the other usages so I can use max_val - min_val directly here
Summary: Add implementation for new qscheme per_channel_affine_float_qparams in observer Test Plan: python test/test_quantization.py TestObserver.test_per_channel_observers Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
supriyar
added a commit
that referenced
this pull request
Aug 7, 2020
Summary: Add implementation for new qscheme per_channel_affine_float_qparams in observer Test Plan: python test/test_quantization.py TestObserver.test_per_channel_observers Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: c4bc6a86b86e7785a8e63bc852b34470af8e7c02 Pull Request resolved: #42690
vkuzo
reviewed
Aug 8, 2020
jerryzh168
reviewed
Aug 8, 2020
vkuzo
approved these changes
Aug 8, 2020
Summary: Add implementation for new qscheme per_channel_affine_float_qparams in observer Test Plan: python test/test_quantization.py TestObserver.test_per_channel_observers Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Add implementation for new qscheme per_channel_affine_float_qparams in observer Test Plan: python test/test_quantization.py TestObserver.test_per_channel_observers Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Add implementation for new qscheme per_channel_affine_float_qparams in observer Test Plan: python test/test_quantization.py TestObserver.test_per_channel_observers Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Add implementation for new qscheme per_channel_affine_float_qparams in observer Test Plan: python test/test_quantization.py TestObserver.test_per_channel_observers Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D23070633](https://our.internmc.facebook.com/intern/diff/D23070633) [ghstack-poisoned]
Summary: Add implementation for new qscheme per_channel_affine_float_qparams in observer Test Plan: python test/test_quantization.py TestObserver.test_per_channel_observers Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D23070633](https://our.internmc.facebook.com/intern/diff/D23070633) [ghstack-poisoned]
Summary: Add implementation for new qscheme per_channel_affine_float_qparams in observer Test Plan: python test/test_quantization.py TestObserver.test_per_channel_observers Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D23070633](https://our.internmc.facebook.com/intern/diff/D23070633) [ghstack-poisoned]
|
This pull request has been merged in 816d37b. |
MauiDesign
pushed a commit
to MauiDesign/PyTorchPyTorch
that referenced
this pull request
Aug 16, 2020
Summary: Add implementation for new qscheme per_channel_affine_float_qparams in observer Test Plan: python test/test_quantization.py TestObserver.test_per_channel_observers Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 3788f494fbb596bd3ae5eba76bac4b7da0e6c887 Pull Request resolved: pytorch/pytorch#42690
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Add implementation for new qscheme per_channel_affine_float_qparams in observer
Test Plan:
python test/test_quantization.py TestObserver.test_per_channel_observers
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D23070633