observers: use clamp instead of min/max in calculate_qparams #43150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
The current logic was expensive because it created tensors on CUDA.
Switching to clamp since it can work without needing to create tensors.
yields a ~20% latency improvement on the CUDA microbenchmark for small tensors
(prev diff: P139074571, this diff: P139074706)
Test Plan:
benchmarks
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D23170427