Let torch.sign support complex types #43243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rule follows those of NumPy: https://numpy.org/doc/stable/reference/generated/numpy.sign.html [ghstack-poisoned]
The rule follows those of NumPy: https://numpy.org/doc/stable/reference/generated/numpy.sign.html [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 9fb4ce3 (more details on the Dr. CI page):
🚧 1 ongoing upstream failure:These were probably caused by upstream breakages that are not fixed yet:
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 19 times. |
The rule follows those of NumPy: https://numpy.org/doc/stable/reference/generated/numpy.sign.html [ghstack-poisoned]
xuhdev
added a commit
that referenced
this pull request
Aug 19, 2020
The rule follows those of NumPy: https://numpy.org/doc/stable/reference/generated/numpy.sign.html ghstack-source-id: 4fa51ec548e904dffc48a3f4d8ab54d632d48e81 Pull Request resolved: #43243
The rule follows those of NumPy: https://numpy.org/doc/stable/reference/generated/numpy.sign.html [ghstack-poisoned]
xuhdev
added a commit
that referenced
this pull request
Aug 19, 2020
The rule follows those of NumPy: https://numpy.org/doc/stable/reference/generated/numpy.sign.html ghstack-source-id: 9904d9cfd158cb49cc2276ad21b05de7c2c50029 Pull Request resolved: #43243
|
OK, thanks. Let me change this to a warning message PR. Looking forward to your implementation! |
|
New PR opened: #43280 Abandoning this one now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
The rule follows those of NumPy: https://numpy.org/doc/stable/reference/generated/numpy.sign.html