Add a warning message that torch.sign would not support complex numbers #43280

xuhdev · 2020-08-19T18:51:34Z

Stack from ghstack:

Add a warning message that torch.sign would not support complex numbers #43280 Add a warning message that torch.sign would not support complex numbers

Differential Revision: D24538769

[ghstack-poisoned]

dr-ci · 2020-08-19T19:01:16Z

💊 CI failures summary and remediations

As of commit e36d887 (more details on the Dr. CI page):

1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

pytorch_linux_xenial_py3_clang5_mobile_build (1/1)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

Oct 23 23:57:43 caused by: Connection refused (os error 111)

Oct 23 23:57:43 ++++ extract_trap_cmd 
Oct 23 23:57:43 ++++ printf '%s\n' '' 
Oct 23 23:57:43 +++ printf '%s\n' cleanup 
Oct 23 23:57:43 ++ trap -- ' 
Oct 23 23:57:43 cleanup' EXIT 
Oct 23 23:57:43 ++ [[ pytorch-linux-xenial-py3-clang5-mobile-build != *pytorch-win-* ]] 
Oct 23 23:57:43 ++ which sccache 
Oct 23 23:57:43 ++ sccache --stop-server 
Oct 23 23:57:43 Stopping sccache server... 
Oct 23 23:57:43 error: couldn't connect to server 
Oct 23 23:57:43 caused by: Connection refused (os error 111) 
Oct 23 23:57:43 ++ true 
Oct 23 23:57:43 ++ rm /var/lib/jenkins/sccache_error.log 
Oct 23 23:57:43 rm: cannot remove '/var/lib/jenkins/sccache_error.log': No such file or directory 
Oct 23 23:57:43 ++ true 
Oct 23 23:57:43 ++ [[ pytorch-linux-xenial-py3-clang5-mobile-build == *rocm* ]] 
Oct 23 23:57:43 ++ SCCACHE_ERROR_LOG=/var/lib/jenkins/sccache_error.log 
Oct 23 23:57:43 ++ SCCACHE_IDLE_TIMEOUT=1200 
Oct 23 23:57:43 ++ RUST_LOG=sccache::server=error 
Oct 23 23:57:43 ++ sccache --start-server 
Oct 23 23:57:43 Starting sccache server...

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 32 times.

anjali411 · 2020-08-19T19:29:08Z

aten/src/ATen/native/UnaryOps.cpp

@@ -266,7 +266,10 @@ Tensor& rsqrt_out(Tensor& result, const Tensor& self) { return unary_op_impl_out
 Tensor rsqrt(const Tensor& self) { return unary_op_impl(self, at::rsqrt_out); }
 Tensor& rsqrt_(Tensor& self) { return unary_op_impl_(self, at::rsqrt_out); }

-Tensor& sign_out(Tensor& result, const Tensor& self) { return unary_op_impl_out(result, self, sign_stub); }
+Tensor& sign_out(Tensor& result, const Tensor& self) {
+  TORCH_CHECK(!self.is_complex(), "Unlike NumPy, torch.sign is not intended to support complex numbers.");


I don't think we need to add this. I think the current error is sufficient.

>>> a=torch.randn(4, dtype=torch.cdouble) >>> a.sign() Traceback (most recent call last): File "<stdin>", line 1, in <module> RuntimeError: "sign_cpu" not implemented for 'ComplexDouble'

Perhaps you can change the message in your #39955 ? This at least points users to the proper function.

sorry I don't follow. which message are you suggesting to update?

This message that I added here: "Unlike NumPy, torch.sign is not intended to support complex numbers. Please use sgn instead."

I don't think we generally add these warning messages unless we are breaking BC or something. cc. @mruberry

Redirecting users to look at torch.sgn (when it becomes available) seems like a helpful error message. It could be separated from the torch.sgn PR (as a follow-up like this). I would wait to add an error message here until torch.sgn is available, though.

I agree that we should either wait until #39955 is merged, or having this message included in #39955 .

@xuhdev can you update the error message to what you mentioned above:
"Unlike NumPy, torch.sign is not intended to support complex tensors. Please use torch.sgn() instead."

anjali411 · 2020-08-19T19:30:10Z

test/test_torch.py

@@ -5985,7 +5985,9 @@ def test_complex_assert_raises(self, device):
                self.assertRaises(RuntimeError,
                                  lambda: zeros.index_add(0, torch.arange(0, size[0], dtype=torch.long, device=device), tensor))

-            self.assertRaises(RuntimeError, lambda: torch.sign(torch.tensor([4j], device=device, dtype=dtype)))
+            with self.assertRaisesRegex(RuntimeError,


thanks good to have a test to check that sign throws an error for complex.

…mplex numbers" [ghstack-poisoned]

ghstack-source-id: 89386811e2ec936ee883d29572770d9be8178d6b Pull Request resolved: #43280

…mplex numbers" [ghstack-poisoned]

ghstack-source-id: 864a3a29e115954730bcafd943f81800f3838fff Pull Request resolved: #43280

xuhdev · 2020-10-20T22:27:03Z

@mruberry @anjali411 Do you think this is ready to merge now? #39955 has been merged.

anjali411 · 2020-10-21T03:27:31Z

@mruberry @anjali411 Do you think this is ready to merge now? #39955 has been merged.

yes looks good after the error message is updated to reference torch.sgn()

…mplex numbers" [ghstack-poisoned]

ghstack-source-id: 684f326cd693d4473c08b4ff7ce6025615e046ec Pull Request resolved: #43280

xuhdev · 2020-10-21T18:32:42Z

@anjali411 I've added the reference now

anjali411

lgtm

…mplex numbers" [ghstack-poisoned]

ghstack-source-id: c8ddbac2c6fcf54c12d4b5cd82a4032f81e59f49 Pull Request resolved: #43280

xuhdev · 2020-10-23T23:51:07Z

Updated the PR to fix an error in the test file

mruberry

Thanks @xuhdev!

facebook-github-bot · 2020-10-27T06:14:50Z

@anjali411 merged this pull request in bcbb6ba.

facebook-github-bot · 2020-10-27T06:15:01Z

@anjali411 merged this pull request in bcbb6ba.

facebook-github-bot · 2020-10-27T06:15:09Z

@anjali411 merged this pull request in bcbb6ba.

Add a warning message that torch.sign would not support complex numbers

b4542dd

[ghstack-poisoned]

xuhdev mentioned this pull request Aug 19, 2020

Do not define the macro "isnan" #43242

Closed

xuhdev requested a review from anjali411 August 19, 2020 18:52

xuhdev mentioned this pull request Aug 19, 2020

Let torch.sign support complex types #43243

Closed

pytorchbot added the open source label Aug 19, 2020

anjali411 reviewed Aug 19, 2020

View reviewed changes

Update on "Add a warning message that torch.sign would not support co…

11706a9

…mplex numbers" [ghstack-poisoned]

xuhdev added a commit that referenced this pull request Aug 19, 2020

Add a warning message that torch.sign would not support complex numbers

d88fe95

ghstack-source-id: 89386811e2ec936ee883d29572770d9be8178d6b Pull Request resolved: #43280

ngimel added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 25, 2020

Update on "Add a warning message that torch.sign would not support co…

0d0444e

…mplex numbers" [ghstack-poisoned]

xuhdev added a commit that referenced this pull request Oct 20, 2020

Add a warning message that torch.sign would not support complex numbers

4e3d091

ghstack-source-id: 864a3a29e115954730bcafd943f81800f3838fff Pull Request resolved: #43280

Update on "Add a warning message that torch.sign would not support co…

35a8f7c

…mplex numbers" [ghstack-poisoned]

xuhdev added a commit that referenced this pull request Oct 21, 2020

Add a warning message that torch.sign would not support complex numbers

daf2d6f

ghstack-source-id: 684f326cd693d4473c08b4ff7ce6025615e046ec Pull Request resolved: #43280

xuhdev requested review from anjali411 and mruberry October 21, 2020 18:32

anjali411 approved these changes Oct 21, 2020

View reviewed changes

Update on "Add a warning message that torch.sign would not support co…

8c0d999

…mplex numbers" [ghstack-poisoned]

Update on "Add a warning message that torch.sign would not support co…

e36d887

…mplex numbers" [ghstack-poisoned]

xuhdev added a commit that referenced this pull request Oct 23, 2020

Add a warning message that torch.sign would not support complex numbers

6697b53

ghstack-source-id: c8ddbac2c6fcf54c12d4b5cd82a4032f81e59f49 Pull Request resolved: #43280

mruberry approved these changes Oct 26, 2020

View reviewed changes

facebook-github-bot closed this in bcbb6ba Oct 27, 2020

facebook-github-bot added the Merged label Oct 27, 2020

xuhdev deleted the gh/xuhdev/88/head branch October 27, 2020 18:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a warning message that torch.sign would not support complex numbers #43280

Add a warning message that torch.sign would not support complex numbers #43280

xuhdev commented Aug 19, 2020 •

edited by anjali411

dr-ci bot commented Aug 19, 2020 •

edited

anjali411 Aug 19, 2020 •

edited

xuhdev Aug 25, 2020

anjali411 Aug 25, 2020

xuhdev Aug 25, 2020

anjali411 Aug 25, 2020 •

edited

mruberry Aug 25, 2020

xuhdev Aug 25, 2020

anjali411 Oct 21, 2020

anjali411 Aug 19, 2020

xuhdev commented Oct 20, 2020

anjali411 commented Oct 21, 2020

xuhdev commented Oct 21, 2020

anjali411 left a comment

xuhdev commented Oct 23, 2020

mruberry left a comment

facebook-github-bot commented Oct 27, 2020

facebook-github-bot commented Oct 27, 2020

facebook-github-bot commented Oct 27, 2020

Add a warning message that torch.sign would not support complex numbers #43280

Add a warning message that torch.sign would not support complex numbers #43280

Conversation

xuhdev commented Aug 19, 2020 • edited by anjali411

dr-ci bot commented Aug 19, 2020 • edited

💊 CI failures summary and remediations

🕵️ 1 new failure recognized by patterns

pytorch_linux_xenial_py3_clang5_mobile_build (1/1)

anjali411 Aug 19, 2020 • edited

Choose a reason for hiding this comment

xuhdev Aug 25, 2020

Choose a reason for hiding this comment

anjali411 Aug 25, 2020

Choose a reason for hiding this comment

xuhdev Aug 25, 2020

Choose a reason for hiding this comment

anjali411 Aug 25, 2020 • edited

Choose a reason for hiding this comment

mruberry Aug 25, 2020

Choose a reason for hiding this comment

xuhdev Aug 25, 2020

Choose a reason for hiding this comment

anjali411 Oct 21, 2020

Choose a reason for hiding this comment

anjali411 Aug 19, 2020

Choose a reason for hiding this comment

xuhdev commented Oct 20, 2020

anjali411 commented Oct 21, 2020

xuhdev commented Oct 21, 2020

anjali411 left a comment

Choose a reason for hiding this comment

xuhdev commented Oct 23, 2020

mruberry left a comment

Choose a reason for hiding this comment

facebook-github-bot commented Oct 27, 2020

facebook-github-bot commented Oct 27, 2020

facebook-github-bot commented Oct 27, 2020

xuhdev commented Aug 19, 2020 •

edited by anjali411

dr-ci bot commented Aug 19, 2020 •

edited

anjali411 Aug 19, 2020 •

edited

anjali411 Aug 25, 2020 •

edited