[jit] allow slicing multiple dimensions with indices #45239
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
Lilyjjo
added a commit
that referenced
this pull request
Sep 23, 2020
ghstack-source-id: 9fd59f36c81182b82a2684cd2b53a928336579b5 Pull Request resolved: #45239
facebook-github-bot
added
the
oncall: jit
gmagogsfm
reviewed
Sep 23, 2020
test/jit/test_list_dict.py
Outdated
| x = x[[0, 1], :, [1]] | ||
| return x | ||
|
|
||
| test_func(test_index_slice1, (a,)) |
There was a problem hiding this comment.
You can use self.checkScript for same functionality.
There was a problem hiding this comment.
Ah, I didn't use that because I wasn't sure if it was comparing the outputs of the scripted vs non-scripted modules. I double checked on the self.checkScript code and I see that it actually does. I'll change it to use that instead :)
💊 CI failures summary and remediationsAs of commit 0c84b75 (more details on the Dr. CI page): Commit 0c84b75 was recently pushed. Waiting for builds... This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 13 times. |
Differential Revision: [D23886919](https://our.internmc.facebook.com/intern/diff/D23886919) [ghstack-poisoned]
Lilyjjo
added a commit
that referenced
this pull request
Oct 1, 2020
Currently investigating issue where indexing with an empty list in eager returns a tensor with a zero-sized dim in the empty list spot *OTOH* the scripted module will throw this error: " RuntimeError: The following operation failed in the TorchScript interpreter. Traceback of TorchScript (most recent call last): RuntimeError: Input must be of ints, floats, or bools, got Tensor Empty lists default to List[Tensor]. Add a variable annotation to the assignment to create an empty list of another type (torch.jit.annotate(List[T, []]) where T is the type of elements in the list for Python 2) " ghstack-source-id: 5f830201f21d626dadef63a9c1677cd90e5078d3 Pull Request resolved: #45239
Lilyjjo
changed the title
Currently investigating issue where indexing with an empty list in eager returns a tensor with a zero-sized dim in the empty list spot *OTOH* the scripted module will throw this error:
" RuntimeError: The following operation failed in the TorchScript interpreter.
Traceback of TorchScript (most recent call last):
RuntimeError: Input must be of ints, floats, or bools, got Tensor
Empty lists default to List[Tensor]. Add a variable annotation to the
assignment to create an empty list of another type
(torch.jit.annotate(List[T, []]) where T is the type of elements in the
list for Python 2) "
Differential Revision: [D23886919](https://our.internmc.facebook.com/intern/diff/D23886919)
[ghstack-poisoned]
Currently investigating issue where indexing with an empty list in eager returns a tensor with a zero-sized dim in the empty list spot *OTOH* the scripted module will throw this error:
" RuntimeError: The following operation failed in the TorchScript interpreter.
Traceback of TorchScript (most recent call last):
RuntimeError: Input must be of ints, floats, or bools, got Tensor
Empty lists default to List[Tensor]. Add a variable annotation to the
assignment to create an empty list of another type
(torch.jit.annotate(List[T, []]) where T is the type of elements in the
list for Python 2) "
Differential Revision: [D23886919](https://our.internmc.facebook.com/intern/diff/D23886919)
[ghstack-poisoned]
Lilyjjo
added a commit
that referenced
this pull request
Oct 5, 2020
Currently investigating issue where indexing with an empty list in eager returns a tensor with a zero-sized dim in the empty list spot *OTOH* the scripted module will throw this error: " RuntimeError: The following operation failed in the TorchScript interpreter. Traceback of TorchScript (most recent call last): RuntimeError: Input must be of ints, floats, or bools, got Tensor Empty lists default to List[Tensor]. Add a variable annotation to the assignment to create an empty list of another type (torch.jit.annotate(List[T, []]) where T is the type of elements in the list for Python 2) " ghstack-source-id: 10c0d1a8d164e9dfe8b1ec6a008782d98388a309 Pull Request resolved: #45239
gmagogsfm
requested changes
Oct 5, 2020
test/jit/test_list_dict.py
Outdated
| x = x[[], :, :] | ||
| return x | ||
|
|
||
| self.checkScript(test_index_slice1, (a,)) |
There was a problem hiding this comment.
Move check right next to its function under test, ideally all of them should become individual small testcases
test/jit/test_list_dict.py
Outdated
| with self.assertRaisesRegex(RuntimeError, "index 4 is out of bounds for dimension 0 with size 3"): | ||
| self.checkScript(test_index_slice4, (a,)) | ||
|
|
||
| with self.assertRaises(RuntimeError): |
There was a problem hiding this comment.
I don't think this test case is needed, please make sure empty sequence with torch.jit.annotate works.
Differential Revision: [D23886919](https://our.internmc.facebook.com/intern/diff/D23886919) [ghstack-poisoned]
Lilyjjo
added a commit
that referenced
this pull request
Oct 5, 2020
Currently investigating issue where indexing with an empty list in eager returns a tensor with a zero-sized dim in the empty list spot *OTOH* the scripted module will throw this error: " RuntimeError: The following operation failed in the TorchScript interpreter. Traceback of TorchScript (most recent call last): RuntimeError: Input must be of ints, floats, or bools, got Tensor Empty lists default to List[Tensor]. Add a variable annotation to the assignment to create an empty list of another type (torch.jit.annotate(List[T, []]) where T is the type of elements in the list for Python 2) " ghstack-source-id: 970d1d69827fbbb7e62aa5ab3d071cc399b8997b Pull Request resolved: #45239
Lilyjjo
changed the title
gmagogsfm
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D23886919