Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jit] allow slicing multiple dimensions with indices #45239

Closed
wants to merge 5 commits into from

Commits on Sep 23, 2020

  1. [jit] allow slicing multiple dimensions with indicies

    [ghstack-poisoned]
    Lilyjjo committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    fd3a769 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2020

  1. Configuration menu
    Copy the full SHA
    ccb5058 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2020

  1. Update on "[WIP] [jit] allow slicing multiple dimensions with indices "

    Currently investigating issue where indexing with an empty list in eager returns a tensor with a zero-sized dim in the empty list spot *OTOH* the scripted module will throw this error:
    " RuntimeError: The following operation failed in the TorchScript interpreter.
        Traceback of TorchScript (most recent call last):
        RuntimeError: Input must be of ints, floats, or bools, got Tensor
        Empty lists default to List[Tensor]. Add a variable annotation to the
        assignment to create an empty list of another type
        (torch.jit.annotate(List[T, []]) where T is the type of elements in the
        list for Python 2) "
    
    Differential Revision: [D23886919](https://our.internmc.facebook.com/intern/diff/D23886919)
    
    [ghstack-poisoned]
    Lilyjjo committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    d2a86ab View commit details
    Browse the repository at this point in the history
  2. Update on "[WIP] [jit] allow slicing multiple dimensions with indices "

    Currently investigating issue where indexing with an empty list in eager returns a tensor with a zero-sized dim in the empty list spot *OTOH* the scripted module will throw this error:
    " RuntimeError: The following operation failed in the TorchScript interpreter.
        Traceback of TorchScript (most recent call last):
        RuntimeError: Input must be of ints, floats, or bools, got Tensor
        Empty lists default to List[Tensor]. Add a variable annotation to the
        assignment to create an empty list of another type
        (torch.jit.annotate(List[T, []]) where T is the type of elements in the
        list for Python 2) "
    
    Differential Revision: [D23886919](https://our.internmc.facebook.com/intern/diff/D23886919)
    
    [ghstack-poisoned]
    Lilyjjo committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    1b87251 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0c84b75 View commit details
    Browse the repository at this point in the history