Add string versions of argument funcs in jit Node #45464
Conversation
|
This pull request was exported from Phabricator. Differential Revision: D23972315 |
facebook-github-bot
added
the
oncall: jit
💊 CI failures summary and remediationsAs of commit c2146b2 (more details on the Dr. CI page): Commit c2146b2 was recently pushed. Waiting for builds... This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 9 times. |
|
This pull request was exported from Phabricator. Differential Revision: D23972315 |
spaugh
force-pushed
the
export-D23972315
branch
from
1cf6690
to
c0d36f8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D23972315 |
spaugh
force-pushed
the
export-D23972315
branch
from
c0d36f8
to
0433159
Compare
Summary: Pull Request resolved: pytorch#45464 Usage of Symbols to find arguments requires one to generate a nonsense symbol for inputs which don't already have one. The intention of symbols appears to be something of an internalized string, but the namespace component doesn't apply to an argument. In order to access the arguments by name without adding new symbols, versions of those functions with std::string input was added. These can be proved valid based on the existing codepath. Additionally, a hasNamedInput convenience function was added to remove the necessity of a try/catch block in user code. The primary motivation is to be able to easily handle the variable number of arguments in glow, so that the arange op may be implemented. Differential Revision: D23972315 fbshipit-source-id: 30570a6ea8180dd70192ccf51019368f5fe078c5
|
This pull request was exported from Phabricator. Differential Revision: D23972315 |
spaugh
force-pushed
the
export-D23972315
branch
from
0433159
to
c2146b2
Compare
There was a problem hiding this comment.
LGTM. Current findArgument api internally converts the symbol to a string anyway, and this is a nicer api. https://github.com/pytorch/pytorch/blob/master/torch/csrc/jit/ir/ir.cpp#L850
|
This pull request has been merged in cdf93b0. |
Summary:
Usage of Symbols to find arguments requires one to generate a nonsense symbol for inputs which don't already have one. The intention of symbols appears to be something of an internalized string, but the namespace component doesn't apply to an argument. In order to access the arguments by name without adding new symbols, versions of those functions with std::string input was added. These can be proved valid based on the existing codepath. Additionally, a hasNamedInput convenience function was added to remove the necessity of a try/catch block in user code.
The primary motivation is to be able to easily handle the variable number of arguments in glow, so that the arange op may be implemented.
Differential Revision: D23972315