Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add string versions of argument funcs in jit Node #45464

Closed
wants to merge 1 commit into from
Closed

Add string versions of argument funcs in jit Node #45464

wants to merge 1 commit into from

Commits on Oct 1, 2020

  1. Add string versions of argument funcs in jit Node (pytorch#45464) 

    Summary:
Pull Request resolved: pytorch#45464

Usage of Symbols to find arguments requires one to generate a nonsense symbol for inputs which don't already have one. The intention of symbols appears to be something of an internalized string, but the namespace component doesn't apply to an argument. In order to access the arguments by name without adding new symbols, versions of those functions with std::string input was added. These can be proved valid based on the existing codepath. Additionally, a hasNamedInput convenience function was added to remove the necessity of a try/catch block in user code.

The primary motivation is to be able to easily handle the variable number of arguments in glow, so that the arange op may be implemented.

Differential Revision: D23972315

fbshipit-source-id: 30570a6ea8180dd70192ccf51019368f5fe078c5
    @spaugh @facebook-github-bot
    spaugh authored and facebook-github-bot committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    c2146b2 View commit details
    Browse the repository at this point in the history