[FX] Make Tracer.trace() just return a Graph #45704
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
jamesr66a
pushed a commit
that referenced
this pull request
Oct 1, 2020
ghstack-source-id: 306a6aa32d4baf6b2d591639e244cecf2c09a5d6 Pull Request resolved: #45704
Adds another layer of customizability. This allows people to do things like wrap up a Graph in a custom subclass of GraphModule, etc. Closes #45534 Differential Revision: [D24067982](https://our.internmc.facebook.com/intern/diff/D24067982) [ghstack-poisoned]
jamesr66a
pushed a commit
that referenced
this pull request
Oct 2, 2020
ghstack-source-id: 187005b1c809252934555184d60f6fb03fd54cb4 Pull Request resolved: #45704
zdevito
approved these changes
Oct 2, 2020
Adds another layer of customizability. This allows people to do things like wrap up a Graph in a custom subclass of GraphModule, etc. Closes #45534 Differential Revision: [D24067982](https://our.internmc.facebook.com/intern/diff/D24067982) [ghstack-poisoned]
jamesr66a
pushed a commit
that referenced
this pull request
Oct 2, 2020
ghstack-source-id: fb5bd95d09f3ae9c2e5f4465cb8025f91f151ae0 Pull Request resolved: #45704
Adds another layer of customizability. This allows people to do things like wrap up a Graph in a custom subclass of GraphModule, etc. Closes #45534 Differential Revision: [D24067982](https://our.internmc.facebook.com/intern/diff/D24067982) [ghstack-poisoned]
jamesr66a
pushed a commit
that referenced
this pull request
Oct 2, 2020
Pull Request resolved: #45704 Differential Revision: [D24067982](https://our.internmc.facebook.com/intern/diff/D24067982/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D24067982/)! ghstack-source-id: 113483533
|
@jamesr66a merged this pull request in 2ab74a4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Adds another layer of customizability. This allows people to do things like wrap up a Graph in a custom subclass of GraphModule, etc.
Closes #45534
Differential Revision: D24067982