Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNX] Fix scripting rand/randn/where #45793

Closed
wants to merge 4 commits into from

Conversation

BowenBao
Copy link
Collaborator

@BowenBao BowenBao commented Oct 3, 2020

  • rand/randn: the type signature of int[] is different in scripting, thus failing the check.
  • where: scripting produces dynamic cases which are supported by unbind export of higher opsets.
  • test_list_pass: this test fails when using new scripting api, should be fixed by [ONNX] Update squeeze test for opset 9 #45369

@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #45793 into master will increase coverage by 0.00%.
The diff coverage is 25.00%.

@@           Coverage Diff           @@
##           master   #45793   +/-   ##
=======================================
  Coverage   60.80%   60.80%           
=======================================
  Files        2747     2747           
  Lines      253928   253934    +6     
=======================================
+ Hits       154397   154408   +11     
+ Misses      99531    99526    -5     

@BowenBao BowenBao changed the title [WIP][ONNX] Fix scripting rand/randn/where [ONNX] Fix scripting rand/randn/where Oct 14, 2020
@BowenBao BowenBao marked this pull request as ready for review October 14, 2020 17:00
@heitorschueroff heitorschueroff added module: onnx Related to torch.onnx module: random Related to random number generation in PyTorch (rng generator) triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Oct 14, 2020
@dr-ci
Copy link

dr-ci bot commented Oct 15, 2020

💊 CI failures summary and remediations

As of commit f25a770 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 5 times.

Copy link
Contributor

@neginraoof neginraoof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for resolving the failures, look good!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

Hi @BowenBao!

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but we do not have a signature on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@bzinodev merged this pull request in e26c172.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed Merged module: onnx Related to torch.onnx module: random Related to random number generation in PyTorch (rng generator) open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants