[ONNX] Enable onnx shape inference in export by default

[BowenBao]

• Enable ONNX shape inference by default.
• ONNX could potentially set inferred shape in output instead of value_infos, checking both to be sure.
• Small fix in symbol_map to avoid overlooking dup symbols.
• Fix scalar_type_analysis to be consistent with PyTorch scalar type promotion logic.
• Correctly handle None dim_param from ONNX inferred shape.

[dr-ci]

💊 CI failures summary and remediations

As of commit f7eae4c (more details on the Dr. CI page):

---

💚 💚 Looks good so far! There are no failures yet. 💚 💚

---

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 76 times.

[codecov]

Codecov Report

Merging #46629 (f7eae4c) into master (eb8331e) will increase coverage by 0.04%.
The diff coverage is 72.85%.

@@            Coverage Diff             @@
##           master   #46629      +/-   ##
==========================================
+ Coverage   81.25%   81.30%   +0.04%     
==========================================
  Files        1838     1838              
  Lines      198270   198318      +48     
==========================================
+ Hits       161114   161241     +127     
+ Misses      37156    37077      -79     

[facebook-github-bot]

Hi @BowenBao!

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but we do not have a signature on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[neginraoof]

I'm not clear about this item:
ONNX could potentially set inferred shape in output instead of value_infos, checking both to be sure.

Is there any other mechanism to specify shape type other than value_infos? What does it mean to check both?

[BowenBao]

I'm not clear about this item:
ONNX could potentially set inferred shape in output instead of value_infos, checking both to be sure.

Is there any other mechanism to specify shape type other than value_infos? What does it mean to check both?

Yes, changes in ONNX 1.8 will write inferred shape for outputs of graph to graph outputs. inferred shape for outputs of intermediate node will still be kept in value_infos.

[neginraoof]

LGTM. THanks!

[facebook-github-bot]

@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@bzinodev merged this pull request in 6a4d55f.