Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maximum number of threads per block for sm_86 is 1536 #45889

Closed
wants to merge 2 commits into from

Conversation

xwang233
Copy link
Collaborator

@xwang233 xwang233 commented Oct 6, 2020

@xwang233 xwang233 requested a review from ngimel October 6, 2020 04:32
@xwang233
Copy link
Collaborator Author

xwang233 commented Oct 6, 2020

cc @ptrblck @mcarilli

@ngimel
Copy link
Collaborator

ngimel commented Oct 6, 2020

Thanks for the PR

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ngimel ngimel changed the title __CUDA_ARCH__ for sm_86 is 1536 maximum number of threads per block for sm_86 is 1536 Oct 6, 2020
@ngimel
Copy link
Collaborator

ngimel commented Oct 6, 2020

I'm concerned though, since we don't (and won't) compile binaries for 8.6, does it mean we could potentially compute wrong number of blocks per sm for 8.0 binaries run on 8.6? I think it's benign, and should not lead to "insufficient resources" error, but could you guys double check?

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #45889 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #45889   +/-   ##
=======================================
  Coverage   68.19%   68.19%           
=======================================
  Files         410      410           
  Lines       53226    53226           
=======================================
  Hits        36297    36297           
  Misses      16929    16929           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf85642...a49811e. Read the comment docs.

xwang233 added a commit to xwang233/pytorch that referenced this pull request Oct 6, 2020
Summary:
according to https://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html#features-and-technical-specifications

Pull Request resolved: pytorch#45889

Reviewed By: albanD

Differential Revision: D24131188

Pulled By: ngimel

fbshipit-source-id: 31d3038f7b1bc403751448c62b19609573c67a49
@facebook-github-bot
Copy link
Contributor

@ngimel merged this pull request in fcc7f27.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants