Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/1.7] maximum number of threads per block for sm_86 is 1536 #45924

Conversation

xwang233
Copy link
Collaborator

@xwang233 xwang233 commented Oct 6, 2020

cherry pick of #45889

This may improve the performance on Ampere GeForce 3080 and 3090.

Summary:
according to https://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html#features-and-technical-specifications

Pull Request resolved: pytorch#45889

Reviewed By: albanD

Differential Revision: D24131188

Pulled By: ngimel

fbshipit-source-id: 31d3038f7b1bc403751448c62b19609573c67a49
@ngimel
Copy link
Collaborator

ngimel commented Oct 6, 2020

tbh, I don't see how it can improve 3080/3090 performance unless we compile for 8.6 cc (which I don't think we are going to do, relying on 8.0 binary compatibility, cc @malfet).

@albanD albanD requested a review from ngimel October 6, 2020 21:21
@albanD albanD added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 6, 2020
@xwang233
Copy link
Collaborator Author

xwang233 commented Oct 6, 2020

sm_86 is enabled in cuda 11.1, so it depends on which cuda version will be compiled for the release.

@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

Merging #45924 into release/1.7 will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/1.7   #45924   +/-   ##
============================================
  Coverage        68.38%   68.38%           
============================================
  Files              406      406           
  Lines            52267    52267           
============================================
+ Hits             35741    35742    +1     
+ Misses           16526    16525    -1     
Impacted Files Coverage Δ
torch/testing/_internal/expecttest.py 78.57% <0.00%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65a1827...19bf085. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

Hi @xwang233!

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but we do not have a signature on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@xwang233 xwang233 closed this Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants