[quant][graph][fix] Set type for GetAttr nodes in remapTypes #46250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Previously the type of GetAttr nodes was getting set incorrectly and wasn't matching the module type Test Plan: Existing quantization tests Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
supriyar
added a commit
that referenced
this pull request
Oct 13, 2020
Summary: Previously the type of GetAttr nodes was getting set incorrectly and wasn't matching the module type Test Plan: Existing quantization tests Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: c9f5919f9112f86d37280212e758e15677c8ad6f Pull Request resolved: #46250
facebook-github-bot
added
the
oncall: jit
Yes, this fixed the bug where the InterfaceType wasn't getting set correctly. Thanks! |
💊 CI failures summary and remediationsAs of commit f56b463 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
| Job | Step | Action |
|---|---|---|
 pytorch_cpp_doc_build |
Doc Build and Push | 🔁 rerun |
This comment was automatically generated by Dr. CI (expand for details).
Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.
This comment has been revised 2 times.
This was referenced Oct 13, 2020
|
This pull request has been merged in 95ccf34. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 15, 2020
Summary: Fixes #45902 by reverting #42457 The test case introduced by #42457 was fixed by #46250, which I'm assuming is the real source of the bug. In the future it would be good to provide repro's for freezing issues without including a quantization dependency; there was another another issue in freezing (see: #46054) who's root cause was the same quantization issue #46250. Pull Request resolved: #46285 Reviewed By: bdhirsh Differential Revision: D24288739 Pulled By: eellison fbshipit-source-id: b69ee8c713f749cd93d5eba370c3eafed86568bb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Previously the type of GetAttr nodes was getting set incorrectly and wasn't matching the module type
Test Plan:
Existing quantization tests
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D24279872