Fix freezing attribute not found #46054
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some model type of GetAttr and attribute types are not the same. This patch handles these scenarios [ghstack-poisoned]
facebook-github-bot
added
the
oncall: jit
Codecov Report
@@ Coverage Diff @@
## gh/bzinodev/20/base #46054 +/- ##
====================================================
Coverage 68.27% 68.27%
====================================================
Files 410 410
Lines 53306 53306
====================================================
Hits 36397 36397
Misses 16909 16909 Continue to review full report at Codecov.
|
This was referenced Oct 13, 2020
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 15, 2020
Summary: Fixes #45902 by reverting #42457 The test case introduced by #42457 was fixed by #46250, which I'm assuming is the real source of the bug. In the future it would be good to provide repro's for freezing issues without including a quantization dependency; there was another another issue in freezing (see: #46054) who's root cause was the same quantization issue #46250. Pull Request resolved: #46285 Reviewed By: bdhirsh Differential Revision: D24288739 Pulled By: eellison fbshipit-source-id: b69ee8c713f749cd93d5eba370c3eafed86568bb
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
In some model type of GetAttr and attribute types are not the same. This patch
handles these scenarios
Differential Revision: D24203081