Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement copysign #46396
Implement copysign #46396
Changes from 2 commits
310bc5e
c4d9155
f04d5cd
acde2be
cc8db7e
74569e2
f9ff9f0
1678724
4c9af86
26ec525
46f7102
9cbe66b
493ea3e
7c22820
79b56c2
35367dd
5ed0a2c
3bad25c
5588954
0bf84f1
cc21795
61915d5
8462fe9
4e092ee
46698db
75fde66
e6ab664
155655c
b62da43
5391b39
c35f0ff
ac5dc13
f4dc913
abc20c4
78b8b6b
01392fb
c6e3e8a
e3e5eed
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure that you need the
self.sign()
here.It will fail gradcheck when you add it to the list in common_method_invocation.py if the formula is wrong. But I think you will need to change this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For instance:
a = tensor(-1.)
b = tensor(1.)
c = torch.copysign(a, b) = tensor(1)
The derivative of
a
is-1
rather thanb.sign() = 1
. Any thought on that?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ho right, the derivative is -1 when we change and 1 otherwise so you need both! Agree with you.
Also there is a corner case at
0
here wheresign()
returns0
. What iscopysign()
doing for that? Is the backward formula good for this case as well?