Fix max_pool2d with ceil_mode bug #46558
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
heitorschueroff
added a commit
that referenced
this pull request
Oct 19, 2020
ghstack-source-id: b2eb789f8760cf997efc065535abd0eeac30de87 Pull Request resolved: #46558
💊 CI failures summary and remediationsAs of commit ff7053d (more details on the Dr. CI page):
Extra GitHub checks: 1 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 3 times. |
💊 CI failures summary and remediationsAs of commit a4f0899 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 39 times. |
This PR fixes a bug with how pooling output shape was computed. Previously, it did not consider the right padding as "part of the image" but the docs do. Now, in ceil mode it allows a kernel window to go off bounds as long as it starts within the image including both paddings. The boolean condition was also wrong, it should be ceil_mode. fixes #45357 [ghstack-poisoned]
heitorschueroff
added a commit
that referenced
this pull request
Oct 20, 2020
ghstack-source-id: 32f9000630b256797535a5dae77bd2dc135eedc2 Pull Request resolved: #46558
This PR fixes a bug with how pooling output shape was computed. Previously, it did not consider the right padding as "part of the image" but the docs do. Now, in ceil mode it allows a kernel window to go off bounds as long as it starts within the image including both paddings. The boolean condition was also wrong, it should be ceil_mode. fixes #45357 TODO - [ ] Ensure existing tests are checking for the correct output size [ghstack-poisoned]
heitorschueroff
added a commit
that referenced
this pull request
Oct 21, 2020
ghstack-source-id: 61d608ceac4abd4cd329fb92dc61ea4c2757cd00 Pull Request resolved: #46558
This PR fixes a bug with how pooling output shape was computed. ## BC Breaking Notes Previously, the pooling code allowed a kernel window to be entirely outside the input and it did not consider right padding as part of the input in the computations. Now, in ceil mode it allows a kernel window to go off bounds as long as it starts within the input including both paddings. If ceil_mode=False, then all kernel windows have to start inside the input, again including both paddings. fixes #45357 TODO - [ ] Ensure existing tests are checking for the correct output size [ghstack-poisoned]
heitorschueroff
added a commit
that referenced
this pull request
Oct 23, 2020
ghstack-source-id: 154dd1690c0001cd0808cc166495914ede0b891d Pull Request resolved: #46558
mruberry
reviewed
Oct 26, 2020
aten/src/ATen/native/quantized/cpu/kernels/QuantizedOpKernels.cpp
Outdated
Show resolved
Hide resolved
mruberry
reviewed
Oct 26, 2020
mruberry
reviewed
Oct 26, 2020
mruberry
reviewed
Oct 26, 2020
This PR fixes a bug with how pooling output shape was computed. ## BC Breaking Notes Previously, the pooling code allowed a kernel window to be entirely outside the input and it did not consider right padding as part of the input in the computations. Now, in ceil mode it allows a kernel window to go off bounds as long as it starts within the input including both paddings. If ceil_mode=False, then all kernel windows have to start inside the input, again including both paddings. fixes #45357 TODO - [x] Ensure existing tests are checking for the correct output size [ghstack-poisoned]
heitorschueroff
added a commit
that referenced
this pull request
Oct 27, 2020
ghstack-source-id: aa499843a0cd91df9b92a4470d2aaf22b6e2b75b Pull Request resolved: #46558
This PR fixes a bug with how pooling output shape was computed. ## BC Breaking Notes Previously, the pooling code allowed a kernel window to be entirely outside the input and it did not consider right padding as part of the input in the computations. Now, in ceil mode it allows a kernel window to go off bounds as long as it starts within the input including both paddings. If ceil_mode=False, then all kernel windows have to start inside the input, again including both paddings. fixes #45357 TODO - [x] Ensure existing tests are checking for the correct output size [ghstack-poisoned]
heitorschueroff
added a commit
that referenced
this pull request
Oct 27, 2020
ghstack-source-id: 5d42f05c70b85d499daf8fd9f7e3c7cb4ac323d5 Pull Request resolved: #46558
mruberry
reviewed
Oct 27, 2020
mruberry
reviewed
Oct 27, 2020
mruberry
reviewed
Oct 27, 2020
mruberry
approved these changes
Oct 27, 2020
This PR fixes a bug with how pooling output shape was computed. ## BC Breaking Notes Previously, a bug in the pooling code allowed a sliding window to be entirely off bounds. Now, sliding windows must start inside the input or left padding (not right padding, see #46929) and may only go off-bounds if ceil_mode=True. fixes #45357 TODO - [x] Ensure existing tests are checking for the correct output size [ghstack-poisoned]
heitorschueroff
added a commit
that referenced
this pull request
Oct 27, 2020
ghstack-source-id: 4f9c04b7291b44e20cc5600ebb224994f5411de1 Pull Request resolved: #46558
This PR fixes a bug with how pooling output shape was computed. ## BC Breaking Notes Previously, a bug in the pooling code allowed a sliding window to be entirely off bounds. Now, sliding windows must start inside the input or left padding (not right padding, see #46929) and may only go off-bounds if ceil_mode=True. fixes #45357 TODO - [x] Ensure existing tests are checking for the correct output size [ghstack-poisoned]
heitorschueroff
added a commit
that referenced
this pull request
Oct 29, 2020
ghstack-source-id: a08a0c29403cd88328bad8927c26fbed8e5348dd Pull Request resolved: #46558
|
@heitorschueroff merged this pull request in 2643800. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This PR fixes a bug with how pooling output shape was computed.
BC Breaking Notes
Previously, a bug in the pooling code allowed a sliding window to be entirely off bounds. Now, sliding windows must start inside the input or left padding (not right padding, see #46929) and may only go off-bounds if ceil_mode=True.
Note
Updating the code to allow the sliding window to start within the right padded region would break many internal assumptions. We may address this in a future PR.
fixes #45357
TODO
Differential Revision: D24633372